Edgewall Software
Modify

Opened 17 years ago

Closed 16 years ago

#6765 closed enhancement (fixed)

Make language select a preference choice

Reported by: Jeroen Ruigrok van der Werven Owned by: Jeroen Ruigrok van der Werven
Priority: normal Milestone: 0.12
Component: i18n Version: devel
Severity: normal Keywords: i18n l10n
Cc: Zoom.Quiet@…, jasminlapalme@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Right now we only use Accept-Language to negotiate the language, but we will need to add a choice in the preferences as well to allow people to set the language using a cookie.

Attachments (1)

i18n_r6891_language_select.patch (2.0 KB ) - added by jasminlapalme@… 17 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by Jeroen Ruigrok van der Werven, 17 years ago

Component: generali18n

comment:2 by Jeroen Ruigrok van der Werven, 17 years ago

Status: newassigned

comment:3 by Jeroen Ruigrok van der Werven, 17 years ago

Committed a first version on the i18n sandbox in r6732.

comment:4 by Jeroen Ruigrok van der Werven, 17 years ago

The only problem in the code is that it does not seem to switch languages. Cursory read-throughs by Alec (aat) and Christopher (cmlenz) indicate that the idea is good.

comment:5 by Zoom.Quiet <Zoom.Quiet@…>, 17 years ago

Cc: Zoom.Quiet@… added

when will move as trunk?

comment:6 by Jeroen Ruigrok van der Werven, 17 years ago

Well, as soon as 0.11 is released.

by jasminlapalme@…, 17 years ago

comment:7 by jasminlapalme@…, 17 years ago

I did a patch to make it work. Well it work for me.

comment:8 by jasminlapalme@…, 17 years ago

Cc: jasminlapalme@… added

comment:9 by Jeroen Ruigrok van der Werven, 17 years ago

Committed in r6929. Thanks.

Seems it has one minor nit with regard to the default language. By the way, if I spelled your name wrong, let me know, I went with Jasmin Lapalme right now.

comment:10 by jasminlapalme@…, 17 years ago

You spell it right.

The default language seems to be the language of the browser.

comment:11 by Jeroen Ruigrok van der Werven, 16 years ago

Resolution: fixed
Status: assignedclosed

This is in place for 0.12 in trunk for a while. Double checked the default language working, it indeed defaults to the browser setup.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jeroen Ruigrok van der Werven.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jeroen Ruigrok van der Werven to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.