Edgewall Software
Modify ↓

Opened 18 years ago

Closed 18 years ago

#6731 closed defect (invalid)

Misleading docstring in trac.versioncontrol.api.Node.get_content_length

Reported by: Carlos Valiente <carlos.valiente@…> Owned by: Christian Boos
Priority: normal Milestone:
Component: version control Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The docstring for get_content_length​ mandates returning None for directories, but _estimate_changes​ expects an integer.

Attachments (0)

Change History (1)

comment:1 by Christian Boos, 18 years ago

Resolution: → invalid
Status: new → closed

Sorry but I don't see the problem: _estimate_changes is a local helper function, called from one place (line 544​) and before calling it, there's an explicit check for the node's type.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.