Edgewall Software

Changes between Initial Version and Version 1 of Ticket #6676


Ignore:
Timestamp:
Jan 21, 2008, 8:50:38 AM (16 years ago)
Author:
Christian Boos
Comment:

This is not implemented for source:sandbox/mercurial-plugin, but it is for source:sandbox/mercurial-plugin-0.11, i.e. the version of the plugin adapted to 0.11. It should be possible to backport the changes, so if you feel like contributing a patch for that, please do.

Btw, the Repository.get_changes() method is only used for comparing two arbitrary paths and/or revs, not for replaying the changes for a given changeset, which is a special case.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6676

    • Property Status new → closed
    • Property Component version control → plugin/mercurial
    • Property Version → 0.10.4
    • Property Resolution → worksforme

  • Ticket #6676 – Description

    initial v1  
    11With Trac 10.4 (installed on a Fedora 8 system via yum) and the TracMercurial plugin taken from the repository head, trying to compare two revisions in the revision log using "View Changes" results in an error:
    2 
     2{{{
    33 Traceback (most recent call last):
    44    File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 406, in dispatch_request
    … …  
    1515      raise !NotImplementedError
    1616  !NotImplementedError
     17}}}
    1718
    1819What's puzzling about this is that [source:tags/trac-0.10.4/trac/versioncontrol/api.py@HEAD#L272 Repository.get_changes] is not overridden in [source:sandbox/mercurial-plugin/tracvc/hg/backend.py the Mercurial plugin], so it appears this functionality could never have worked at all.  But I assume that's not true or the diffs on the TracMercurial page couldn't have been produced.  Any clues?