Edgewall Software
Modify

Opened 16 years ago

Closed 15 years ago

Last modified 11 years ago

#6521 closed defect (wontfix)

put save before cancel in admin forms

Reported by: gsf@… Owned by: Christopher Lenz
Priority: normal Milestone:
Component: admin/web Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The current behavior for many of the forms in WebAdmin is unexpected, at least in Firefox. When one hits the enter key, it cancels instead of submitting because the cancel button comes before the submit button. This patch flips them around.

Attachments (2)

save_cancel.diff (2.1 KB ) - added by gsf@… 16 years ago.
save before cancel patch
save_cancel_i18n.diff (2.4 KB ) - added by gsf@… 16 years ago.
new diff to handle i18n changes

Download all attachments as: .zip

Change History (8)

by gsf@…, 16 years ago

Attachment: save_cancel.diff added

save before cancel patch

comment:1 by gsf@…, 16 years ago

Note that this is a patch on core, not the WebAdmin plugin.

comment:2 by anonymous, 16 years ago

Maybe there should also be a reset button, to revert the currently made changes..

in reply to:  2 comment:3 by Emmanuel Blot, 16 years ago

Replying to anonymous:

Maybe there should also be a reset button, to revert the currently made changes..

I don't think it is worth cluttering the interface with a rarely used function that can be executed anyway with a simple page refresh.

by gsf@…, 16 years ago

Attachment: save_cancel_i18n.diff added

new diff to handle i18n changes

comment:4 by Remy Blank, 15 years ago

Resolution: wontfix
Status: newclosed

There's a consistency issue here: all forms in Trac have a non-committing action as the default ("Preview" for wiki an ticket, "Cancel" for admin, etc.). This also avoids triggering "dangerous" actions inadvertently with ENTER.

I would say that this is a good thing (tm).

comment:5 by gsf@…, 15 years ago

I'd say there's a big difference between preview and cancel, and cancel should never be the default action on a form, but I'll leave this at wontfix.

comment:6 by Ryan J Ollos, 11 years ago

This issue is being discussed again in #11076, where this ticket has been mentioned.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.