#6423 closed enhancement (fixed)
Full diff option in changeset view
| Reported by: | Jeroen Ruigrok van der Werven | Owned by: | Remy Blank |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | version control/changeset view | Version: | |
| Severity: | normal | Keywords: | diffoptions bitesized |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
If possible, we should offer the option to show the complete file as context to the diff next to the current option of X lines.
Attachments (2)
Change History (10)
comment:1 by , 16 years ago
| Resolution: | → worksforme |
|---|---|
| Status: | new → closed |
comment:2 by , 16 years ago
| Keywords: | diffoptions added |
|---|---|
| Milestone: | → 0.12 |
| Resolution: | worksforme |
| Status: | closed → reopened |
As discussed on Trac-dev, this could indeed be improved.
Proposed interface:
(o) Show ___ lines around each change ( ) Show the changes in full context
Another advantage of dissociating the two would be that we won't change the saved contextlines information in the session when occasionally selecting the "show in full context" variant. Also, as this is a potentially expensive way to show a changeset, better let the user make that choice each time he feels he need it, instead of saving that option.
comment:3 by , 15 years ago
| Milestone: | 0.13 → 0.12 |
|---|
comment:5 by , 14 years ago
| Keywords: | bitesized added |
|---|
by , 14 years ago
| Attachment: | 6423_patch added |
|---|
Added a radio button for choosing full context view, clicking on the labels selects the right checkbox (+js to focus() the textbox), Fixed old behavior of accepting bad strings in contextlines textbox, print an error on bad inputs
by , 14 years ago
| Attachment: | patch_6423_fix_warning_cache added |
|---|
Enforces re-rendering of the changeset page if there's a warning or a notice (Depends on the previously attached patch of this bug)
comment:6 by , 14 years ago
| Milestone: | next-minor-0.12.x → 0.12 |
|---|---|
| Owner: | changed from to |
| Status: | reopened → new |
I'll review the patches.
comment:7 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The first patch was a tad bit on the complicated side, and not quite ideal for several reasons:
- The "full context" setting was stored in the session data, contrary to what was suggested in comment:2.
- Using JavaScript is not really necessary.
- Displaying a warning for invalid values is only disturbing, and requires the ugly hack in the second patch to force rendering. We can just treat any invalid value the same as "all".
So I have reworked the patch and made it to conform to comment:2, together with some cleanup. The result is [9322].
comment:8 by , 14 years ago
Would be nice if the (diff) link in the file browser would activate this mode.
It already is: simply enter e.g. 'all' for the number of lines of context, or the empty string.
And as surprising as it seems, it's even documented in TracChangeset#DiffViews.