Edgewall Software
Modify

Opened 13 years ago

Closed 11 years ago

Last modified 11 years ago

#6423 closed enhancement (fixed)

Full diff option in changeset view

Reported by: Jeroen Ruigrok van der Werven Owned by: Remy Blank
Priority: normal Milestone: 0.12
Component: version control/changeset view Version:
Severity: normal Keywords: diffoptions bitesized
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

If possible, we should offer the option to show the complete file as context to the diff next to the current option of X lines.

Attachments (2)

6423_patch (6.7 KB ) - added by Oren Held <oren@…> 11 years ago.
Added a radio button for choosing full context view, clicking on the labels selects the right checkbox (+js to focus() the textbox), Fixed old behavior of accepting bad strings in contextlines textbox, print an error on bad inputs
patch_6423_fix_warning_cache (1.4 KB ) - added by Oren Held <oren@…> 11 years ago.
Enforces re-rendering of the changeset page if there's a warning or a notice (Depends on the previously attached patch of this bug)

Download all attachments as: .zip

Change History (10)

comment:1 by Christian Boos, 13 years ago

Resolution: worksforme
Status: newclosed

It already is: simply enter e.g. 'all' for the number of lines of context, or the empty string.

And as surprising as it seems, it's even documented in TracChangeset#DiffViews.

comment:2 by Christian Boos, 13 years ago

Keywords: diffoptions added
Milestone: 0.12
Resolution: worksforme
Status: closedreopened

As discussed on Trac-dev, this could indeed be improved.

Proposed interface:

(o) Show ___ lines around each change
( ) Show the changes in full context

Another advantage of dissociating the two would be that we won't change the saved contextlines information in the session when occasionally selecting the "show in full context" variant. Also, as this is a potentially expensive way to show a changeset, better let the user make that choice each time he feels he need it, instead of saving that option.

comment:3 by Christian Boos, 12 years ago

Milestone: 0.130.12

comment:4 by Remy Blank, 11 years ago

Milestone: 0.12next-minor-0.12.x

Not a blocker for 0.12.

comment:5 by Remy Blank, 11 years ago

Keywords: bitesized added

by Oren Held <oren@…>, 11 years ago

Attachment: 6423_patch added

Added a radio button for choosing full context view, clicking on the labels selects the right checkbox (+js to focus() the textbox), Fixed old behavior of accepting bad strings in contextlines textbox, print an error on bad inputs

by Oren Held <oren@…>, 11 years ago

Enforces re-rendering of the changeset page if there's a warning or a notice (Depends on the previously attached patch of this bug)

comment:6 by Remy Blank, 11 years ago

Milestone: next-minor-0.12.x0.12
Owner: changed from Christian Boos to Remy Blank
Status: reopenednew

I'll review the patches.

comment:7 by Remy Blank, 11 years ago

Resolution: fixed
Status: newclosed

The first patch was a tad bit on the complicated side, and not quite ideal for several reasons:

  • The "full context" setting was stored in the session data, contrary to what was suggested in comment:2.
  • Using JavaScript is not really necessary.
  • Displaying a warning for invalid values is only disturbing, and requires the ugly hack in the second patch to force rendering. We can just treat any invalid value the same as "all".

So I have reworked the patch and made it to conform to comment:2, together with some cleanup. The result is [9322].

comment:8 by Christian Boos, 11 years ago

Would be nice if the (diff) link in the file browser would activate this mode.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.