Wrong functionality for always_update_updater ?

[kirean@…]

Hi

Not sure whether this is a defect or an enhancement request.

On wiki:0.11/TracIni, always_notify_updater has the following description:

always_notify_updater

Always send notifications to the person who causes the ticket property change.

The effect of always_notify_updater is though that all persons which ever commented on a ticket gets the notifications.

I am changing the description on wiki:0.11/TracIni now, but I would like the possibility to have the functionality described in the original description, i.e. get notifications when commenting on a ticket.

Should we have something like always_notify_updater and always_notify_updaters where always_notify_updater really does what's described and always_notify_updaters does what always_notify_updater currently does?

Also see: #4426, comment:ticket:153:24

[kirean@…]

I'm not sure on how to update this information since the wiki:0.11/TracIni is using the TracIni-macro.

[Christian Boos]

Just add a == Suggested Updates == section there.

[anonymous]

+1 I'd like to see this enhancement with always_notify_updater and always_notify_updaters

[anonymous]

Here is a patch that does just this. Although it does break backward compatibility a bit, it would be trivial to change 'always_notify_updaters' back to 'always_notify_updater' and change 'always_notify_updater' to 'always_notify_current_updater'…

[anonymous]

Suggestion to avoid the BC issue:

have always_notify_updaters be one of 'true','false','always_notify_updater'. If its 'always_notfy_updater', then it uses the value of always_notify_updater, and of course, that would be the default.

If I'm understanding this properly,

always_notify_updater=false
always_notify_updaters=true

would not send a notification to the person that just submitted the change, but it would send a notification to everyone else who has ever commented on the ticket.

This, IMHO, would be a nice behaviour - I don't need to see the change that I just did, but I do care if someone further updates that ticket.

[Sebastian Krysmanski <sebastian@…>]

This is a duplicate of tickets #8287 (changed description) and #2247 (patch provided to fix the self notification problem).