Edgewall Software
Modify

Opened 17 years ago

Closed 6 years ago

#6200 closed defect (duplicate)

changeset view does not render EOL change on last row

Reported by: theultramage@… Owned by:
Priority: normal Milestone:
Component: version control/changeset view Version: devel
Severity: normal Keywords: mimeview diff
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by theultramage@…)

Today there was an update in our project that added trailing newlines to get rid of "No newline at end of file". The trac changeset view does not render any of those changes.

Tested this on 0.10.4 release and r6049 trunk. This is definitely related to #6199.

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 17 years ago

Keywords: mimeview diff added
Milestone: 0.12

Notice that trac changeset view does not render any of those.

Yeah, there's some refactoring needed so that the changeset diff viewer and patch renderer share more code. They're not working on the same kind of input though, and I'm not sure yet about how the difflib's SequenceMatcher represents a missing newline at the end of one file.

comment:2 by theultramage@…, 10 years ago

Description: modified (diff)
Resolution: fixed
Status: newclosed

This was fixed at some point in the past.

comment:3 by Peter Suter, 10 years ago

Resolution: fixed
Status: closedreopened

I still see the problem. (.splitlines() hides missing newlines.)

In what version of Trac do you see this fixed?

comment:4 by Ryan J Ollos, 9 years ago

Owner: Christian Boos removed
Status: reopenednew

comment:5 by Jun Omae, 6 years ago

Milestone: next-major-releases
Resolution: duplicate
Status: newclosed

#5420 includes this issue.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.