TracException should have `__unicode__()` method for non ASCII message

[Shun-ichi Goto <shunichi.goto@…>]

While playing with i18n branch, there's a problem to raise exception with translated message. TracException class should have __unicode__() method to use non-ASCII exception message. Otherwise, we will get UnicodeEncodeError. (Ex., see changeset.py line 878​)

trac/core.py

@@ -37 +37 @@
         if title:
             self.title = title
         self.show_traceback = show_traceback
+        
+    def __unicode__(self):
+        return unicode(self.message)
 
 
 class Interface(object):

This issue is realized on i18n branch code, but 0.11-dev trunk code has also.

[hyuga <hyugaricdeau@…>]

I second this—I just ran into the same problem. It's an easy fix, and should be included in 0.11.

[Christian Boos]

Well, this unicode(self.message) won't work if self.message itself is not already convertible to unicode, but I guess that would be yet another problem.

So actually the patch looks good.

[Christian Boos]

Committed in r6984 (on the i18n branch as well, where the reporter discovered the issue and where I was able to reproduce it).

Should land on trunk when the branch gets merged.

I think it can be backported to 0.11-stable as well.

[Christian Boos]

Ok for the backport?

[Christian Boos]

Committed as [7397] on 0.11-stable. Thanks for the patch!