trac-admin should show the backtrace for internal errors

[Christian Boos]

We already added some traceback.print_exc() for some commands, but I think this would be useful for all commands. The problem is that Cmd.cmdloop() catches all exceptions, so we'd need to do that for each do_... method. Then we still want to be compatible with Python 2.3, so we can't use decorators for that.

I came up with this:

trac/admin/console.py

@@ -32 +32 @@
 from trac.env import Environment
 from trac.perm import PermissionSystem
 from trac.ticket.model import *
+from trac.util.compat import partial
 from trac.util.datefmt import parse_date, format_date, format_datetime, utc
 from trac.util.html import html
 from trac.util.text import print_table, to_unicode, wrap
@@ -1132 +1133 @@
 
         print 'Hotcopy done.'
 
+def backtrace_on_internal_errors(meth, self, *args, **kwargs):
+    try:
+        meth(self, *args, **kwargs)
+    except TracError, e:
+        raise
+    except Exception, e:
+        print 'Internal error: ', e
+        traceback.print_exc()
+        sys.exit(1)
+        
+for symbol in TracAdmin.__dict__.keys():
+    if symbol.startswith('do_'):
+        setattr(TracAdmin, symbol, partial(backtrace_on_internal_errors,
+                                           getattr(TracAdmin, symbol)))
 
+
 class TracAdminHelpMacro(WikiMacroBase):
     """Displays help for trac-admin commands.
 

which works fine, but I wonder if there's a more elegant way to achieve this.

Opinions welcomed.

[ThurnerRupert]

more elegant than 5 lines of code? i don't know :)

[Christian Boos]

Well, I simply overlooked that we were catching all the exceptions, in onecmd…

See r5962.