#582 closed defect (fixed)
wiki formatting problem: tables are not indented
Reported by: | vittorio | Owned by: | Alec Thomas |
---|---|---|---|
Priority: | normal | Milestone: | 0.10 |
Component: | wiki system | Version: | devel |
Severity: | normal | Keywords: | table |
Cc: | vittorio@… | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
tables arent indented when starting the lines with a few spaces. for example:
||A||B|| ||C||D||
A B
C D
following html code is generated:
<blockquote> </blockquote> <table class="wiki"> <tr></td></tr></table> <p> <td>A</td><td>B </p> <blockquote> <blockquote> </blockquote> </blockquote> <table class="wiki"> <tr></td></tr></table> <p> <td>C</td><td>D </p>
using trunk r790
Attachments (1)
Change History (16)
comment:1 by , 20 years ago
Status: | new → assigned |
---|
comment:2 by , 20 years ago
Milestone: | 0.8 → 0.9 |
---|
comment:3 by , 20 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 by , 20 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:5 by , 19 years ago
Cc: | added |
---|
comment:9 by , 19 years ago
Milestone: | 1.0 → 0.10 |
---|
by , 19 years ago
Attachment: | indented-tables.diff added |
---|
Patch against r3234 with minor fix for paragraph breaks
comment:11 by , 19 years ago
Owner: | changed from | to
---|---|
Status: | reopened → new |
comment:12 by , 19 years ago
Keywords: | table added |
---|
Alec, I've tested the patch and it works well. I think you can commit it.
comment:13 by , 19 years ago
I found a bug unfortunately :( If tables are separated by newlines I can make it work, but if they are like this:
||a|| ||b|| ||c||
The third table is joined with the second. Anyway, I'll keep playing until I figure it out :)
comment:14 by , 19 years ago
Yes, I've seen that too, but it didn't bothered me that much: it's something that the user can easily "fix" by adding an extra newline, whereas the other problems your patch fixes can't be fixed by the user. So I think that applying the patch and keeping note of the above issue is better that leaving the issue open waiting for the "perfect" fix (which will only be perfect until someone find another edge case anyway :) ).
comment:15 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Okay, I think I've hit a good compromise in r3261. Indented tables work 100% correctly, except that rows can no longer be separated by blank lines.
Please, don't close a bug without a comment stating why you closed it.
By the way, the generated HTML with the current trunk is still the same as the one reported, so the problem (if there is a problem) remains.