Edgewall Software
Modify

Opened 20 years ago

Closed 18 years ago

Last modified 8 years ago

#582 closed defect (fixed)

wiki formatting problem: tables are not indented

Reported by: vittorio Owned by: Alec Thomas
Priority: normal Milestone: 0.10
Component: wiki system Version: devel
Severity: normal Keywords: table
Cc: vittorio@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

tables arent indented when starting the lines with a few spaces. for example:

  ||A||B||

    ||C||D||
AB
CD

following html code is generated:

<blockquote>
</blockquote>
<table class="wiki">
<tr></td></tr></table>

<p>
<td>A</td><td>B
</p>
<blockquote>
<blockquote>
</blockquote>
</blockquote>
<table class="wiki">
<tr></td></tr></table>
<p>
<td>C</td><td>D
</p>

using trunk r790

Attachments (1)

indented-tables.diff (2.5 KB ) - added by Alec Thomas 18 years ago.
Patch against r3234 with minor fix for paragraph breaks

Download all attachments as: .zip

Change History (16)

comment:1 by Jonas Borgström, 20 years ago

Status: newassigned

comment:2 by Jonas Borgström, 20 years ago

Milestone: 0.80.9

comment:3 by anonymous, 19 years ago

Resolution: fixed
Status: assignedclosed

comment:4 by Christian Boos, 19 years ago

Resolution: fixed
Status: closedreopened

Please, don't close a bug without a comment stating why you closed it.

By the way, the generated HTML with the current trunk is still the same as the one reported, so the problem (if there is a problem) remains.

comment:5 by vittorio, 19 years ago

Cc: vittorio@… added

comment:6 by Christopher Lenz, 18 years ago

Milestone: 0.90.9.1

Postponing again.

comment:7 by Christopher Lenz, 18 years ago

Milestone: 0.9.10.9.2

And again.

comment:8 by Christopher Lenz, 18 years ago

Milestone: 0.9.31.0

And again.

comment:9 by Christopher Lenz, 18 years ago

Milestone: 1.00.10

comment:10 by Alec Thomas, 18 years ago

Seems to work, all unit tests pass.

by Alec Thomas, 18 years ago

Attachment: indented-tables.diff added

Patch against r3234 with minor fix for paragraph breaks

comment:11 by Alec Thomas, 18 years ago

Owner: changed from Jonas Borgström to Alec Thomas
Status: reopenednew

comment:12 by Christian Boos, 18 years ago

Keywords: table added

Alec, I've tested the patch and it works well. I think you can commit it.

comment:13 by Alec Thomas, 18 years ago

I found a bug unfortunately :( If tables are separated by newlines I can make it work, but if they are like this:

||a||
  ||b||
||c||

The third table is joined with the second. Anyway, I'll keep playing until I figure it out :)

comment:14 by Christian Boos, 18 years ago

Yes, I've seen that too, but it didn't bothered me that much: it's something that the user can easily "fix" by adding an extra newline, whereas the other problems your patch fixes can't be fixed by the user. So I think that applying the patch and keeping note of the above issue is better that leaving the issue open waiting for the "perfect" fix (which will only be perfect until someone find another edge case anyway :) ).

comment:15 by Alec Thomas, 18 years ago

Resolution: fixed
Status: newclosed

Okay, I think I've hit a good compromise in r3261. Indented tables work 100% correctly, except that rows can no longer be separated by blank lines.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Alec Thomas to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.