Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#5793 closed defect (worksforme)

TrackQuery Macro sets order to id, regardless of parameter

Reported by: Noam Tamim <noamtm@…> Owned by: Christian Boos
Priority: normal Milestone:
Component: wiki system Version: 0.10.4
Severity: normal Keywords: ticket, wiki, query, TicketQuery, order
Cc: Noah Kantrowitz Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The cause is this line: http://trac.edgewall.org/browser/tags/trac-0.10.4/trac/ticket/query.py#L707

which says: query.order = 'id'

I commented it out, and now TicketQuery works as expected.

I realize this is probably not needed for 0.11, but if there's a 0.10.5 release before that, it should be included. Either remove the line, or add a comment that explains why it's there.

Attachments (0)

Change History (7)

comment:1 by Eli Carter, 17 years ago

Resolution: duplicate
Status: newclosed

Looks like this got submitted twice by accident. Dup of #5792.

comment:2 by Noam Tamim <noamtm@…>, 17 years ago

Resolution: duplicate
Status: closedreopened

My mess - please keep this one open, the other one closed.

comment:3 by Noah Kantrowitz, 17 years ago

Resolution: worksforme
Status: reopenedclosed

This already works fine on trunk.

comment:4 by Noam Tamim <noamtm@…>, 17 years ago

Cc: Noah Kantrowitz added

I realize it works fine on the trunk. But it doesn't on the latest RELEASE, which is the 0.10 line, or version 0.10.4. That's why the fix should be done in branches/0.10-stable/trac/ticket/query.py, which will include it in the 0.10.5 release.

I'm not reopening, because I don't know if 0.10.5 is even planned before 0.11 is released. But please do if is.

in reply to:  4 ; comment:5 by Noah Kantrowitz, 17 years ago

Replying to Noam Tamim <noamtm@gmail.com>:

I realize it works fine on the trunk. But it doesn't on the latest RELEASE, which is the 0.10 line, or version 0.10.4. That's why the fix should be done in branches/0.10-stable/trac/ticket/query.py, which will include it in the 0.10.5 release.

We do not backport features on to the stable branch, only security and stability fixes. If you really care you can probably grab the new macro from trunk and backport it as a standalone plugin.

in reply to:  5 comment:6 by Noam Tamim <noamtm@…>, 17 years ago

Replying to nkantrowitz:

We do not backport features on to the stable branch, only security and stability fixes. If you really care you can probably grab the new macro from trunk and backport it as a standalone plugin.

There's no porting work to do. The new macro is very different, and seems to be using a different API altogether. The fix is removing a line of code from the macro. I don't "care", because now it works fine for me; however, I'm thinking about new users of the 0.10 line.

comment:7 by Emmanuel Blot, 17 years ago

Milestone: 0.10.5

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.