TrackQuery Macro sets order to id, regardless of parameter

[Noam Tamim <noamtm@…>]

The cause is this line: ​http://trac.edgewall.org/browser/tags/trac-0.10.4/trac/ticket/query.py#L707

which says: query.order = 'id'

I commented it out, and now TicketQuery works as expected.

I realize this is probably not needed for 0.11, but if there's a 0.10.5 release before that, it should be included. Either remove the line, or add a comment that explains why it's there.

[Eli Carter]

Looks like this got submitted twice by accident. Dup of #5792.

[Noam Tamim <noamtm@…>]

My mess - please keep this one open, the other one closed.

[Noah Kantrowitz]

This already works fine on trunk.

[Noam Tamim <noamtm@…>]

I realize it works fine on the trunk. But it doesn't on the latest RELEASE, which is the 0.10 line, or version 0.10.4. That's why the fix should be done in branches/0.10-stable/trac/ticket/query.py​, which will include it in the 0.10.5 release.

I'm not reopening, because I don't know if 0.10.5 is even planned before 0.11 is released. But please do if is.

[Noah Kantrowitz]

Replying to Noam Tamim <noamtm@gmail.com>:

I realize it works fine on the trunk. But it doesn't on the latest RELEASE, which is the 0.10 line, or version 0.10.4. That's why the fix should be done in branches/0.10-stable/trac/ticket/query.py​, which will include it in the 0.10.5 release.

We do not backport features on to the stable branch, only security and stability fixes. If you really care you can probably grab the new macro from trunk and backport it as a standalone plugin.

[Noam Tamim <noamtm@…>]

Replying to nkantrowitz:

We do not backport features on to the stable branch, only security and stability fixes. If you really care you can probably grab the new macro from trunk and backport it as a standalone plugin.

There's no porting work to do. The new macro is very different, and seems to be using a different API altogether. The fix is removing a line of code from the macro. I don't "care", because now it works fine for me; however, I'm thinking about new users of the 0.10 line.