Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#5735 closed defect (fixed)

[PATCH] `split_page_names` splits two-letter words wrong

Reported by: erose Owned by: Christian Boos
Priority: high Milestone: 0.10.5
Component: wiki system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

If you turn on split_page_names, "InstallPloneOnMac" renders as "Install Plone OnMac". That's wrong. This patch makes it render as "Install Plone On Mac", hopefully without breaking anything else:

  • trunk/trac/wiki/api

    old new  
    266266    # See http://www.w3.org/TR/REC-xml/#id,
    267267    # here adapted to exclude terminal "." and ":" characters
    268268
    269     PAGE_SPLIT_RE = re.compile(r"([a-z])([A-Z][a-z])")
     269    PAGE_SPLIT_RE = re.compile(r"([a-z])([A-Z])(?=[a-z])")
    270270   
    271271    def format_page_name(self, page, split=False):
    272272        if split or self.split_page_names:

Attachments (0)

Change History (3)

comment:1 by erose, 17 years ago

Milestone: 0.10.50.11
Version: 0.10.4devel

This is a problem in 0.10.4, too. The patch is trivial to backport.

comment:2 by Christian Boos, 17 years ago

Milestone: 0.110.10.5
Status: newassigned

Very nice. I don't think that'll break anything.

comment:3 by Christian Boos, 17 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in r5854 and ported to 0.10-stable in r5855.

Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.