Non-egg plugins show up multiple times in a multi-project setup

[Dave Abrahams <dave@…>]

For simple, single-python-file plugins, my admin panel shows N checkboxes where N is the number of trac instances in my multi-project environment.

[Dave Abrahams <dave@…>]

I take it back; N is seemingly random. And this is not a benign presentation bug; the plugins will take effect N times. That can result in N transformations of the same wiki text, for example, where only one was intended.

[Christian Boos]

N corresponds to the number of environments that have been activated so far and that contain a version of the plugin.

It's a serious issue but I don't think it's 0.11 specific. Can someone checks if this happens on 0.10-stable as well?

[Dave Abrahams <dave@…>]

Replying to cboos:

N corresponds to the number of environments that have been activated so far and that contain a version of the plugin.

I'm pretty sure it's not that, unless I don't understand what you mean by "activated so far." My setup has 9 trac environments. The attached screenshot is just the first of 5 similar pages!

[Dave Abrahams <dave@…>]

Screeshot of Admin panel

[Dave Abrahams <dave@…>]

FWIW I am using [inherit] to share a single plugins directory.

[Christian Boos]

Well, when I start a server with two environments, each containing a few single file plugins in <env>/plugins, then everything is fine for the first environment I visit (/admin/plugins lists the expected plugins). Then, I go to the second environment and there I see the expected plugins, plus the ones already loaded by the first environment. Going back to the first env now will also show all mixed plugins.

This is with 0.10.5dev. I somehow have the impression this is old news, but I can't find a pre-existing ticket.

In your case, there could be additional issues…

[osimons <simon-code@…>]

I think the problem could be fixed by the changes in the plugin loader made at [6016:6017].

Could you please verify?

[osimons]

In case we want this for 0.10 (which is probably a good idea), I've tested this patch on that branch as well (as of r 6233):

0.10-stable/trac/loader.py

@@ -49 +49 @@
                 if plugin_name not in loaded_components:
                     env.log.debug('Loading file plugin %s from %s' % \
                                   (plugin_name, plugin_file))
-                    module = imp.load_source(plugin_name, plugin_file)
+                    if plugin_name not in sys.modules:
+                        module = imp.load_source(plugin_name, plugin_file)
                     loaded_components.append(plugin_name)
                     if auto_enable and plugin_name + '.*' \
                             not in env.config['components']:

Think it should be correct - works fine for me, but more testing is welcome.

[Christian Boos]

+1 for backporting this

[osimons]

Replying to cboos:

+1 for backporting this

Ported in [6256]. Closes ticket.