Edgewall Software
Modify ↓

Opened 17 years ago

Closed 15 years ago

#5625 closed defect (fixed)

SpamFilter extlinks and division by zero errors

Reported by: shawnw@… Owned by:
Priority: normal Milestone: plugin - spam-filter
Component: plugin/spamfilter Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Setting the max_external_links config variable to 0 causes the extlinks spam filter to raise division by zero errors instead of lowering the karma of a submission with any external links.

The test method of ExternalLinksFilterStrategy ends up doing a 

return -abs(self.karma_points) * num_ext / self.max_links, ...

which causes the error.

On the plus side, it looks like setting max_external_links to 1 will do what I want.

Attachments (0)

Change History (3)

comment:1 by Remy Blank, 16 years ago

Milestone: → not applicable

comment:2 by Christian Boos, 15 years ago

Milestone: not applicable → spam-filter-plugin
Owner: Matthew Good removed

comment:3 by Dirk Stöcker, 15 years ago

Resolution: → fixed
Status: new → closed

In r9881.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.