Edgewall Software
Modify

Opened 10 years ago

Last modified 3 years ago

#5441 new defect

Timeline shows incomplete information about status changes for customized workflow

Reported by: anonymous Owned by:
Priority: normal Milestone: next-major-releases
Component: timeline Version: devel
Severity: normal Keywords: workflow i18n
Cc: mpotter@…, jrioux@…, ethan.jucovy@…, Ryan J Ollos, Jun Omae
Release Notes:
API Changes:

Description

Currently 'Timeline' shows details about status transitions only for few standard values ('new', 'reopened' and 'closed') and everything else shows as "status changed", which is not very convenient if custom workflow has more states.

We could have something like records in ticket's change history.

Sample patch is attached.

More generic solution (e.g. show changes in custom fields similarly) could be even better…

Attachments (1)

web_ui_timeline.diff (1.3 KB ) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by anonymous

Attachment: web_ui_timeline.diff added

comment:1 Changed 10 years ago by Christian Boos

Keywords: workflow consider added
Milestone: 0.11

Looks interesting, we will test it.

comment:2 Changed 10 years ago by Christian Boos

Milestone: 0.11.10.11
Owner: changed from Christian Boos to Eli Carter

eli can you please have a look at this?

comment:3 Changed 10 years ago by Eli Carter

My concern is that the 'status' variable here is going to have problems if someone sets up a workflow with an 'edit' state.

I wonder if the workflow config should support action.past_tense = …

comment:4 Changed 10 years ago by ThurnerRupert

Milestone: 0.110.11.1

no degression to 0.10, seems to unnecessarily block 0.11.

comment:5 Changed 10 years ago by Eli Carter

#194 is also related: we may want the verb to differ based on the ticket type.

Also, the verbs we have been using have been based on ticket status, not on the action taken to get to that status.

comment:6 Changed 9 years ago by Christian Boos

Milestone: 0.11-retriage0.12

… and this gets even more complicated due to i18n.

comment:7 Changed 8 years ago by Christian Boos

Keywords: i18n added; consider removed
Owner: Eli Carter deleted
Severity: minornormal

comment:8 Changed 8 years ago by Remy Blank

Milestone: 0.12next-minor-0.12.x

I'd say that the original request could wait for 0.12.1, or even for 0.13.

comment:9 Changed 7 years ago by mpotter@…

Cc: mpotter@… added

comment:10 Changed 7 years ago by jrioux@…

Cc: jrioux@… added

comment:11 Changed 4 years ago by ethan.jucovy@…

Cc: ethan.jucovy@… added

In attachment:workflow-aware-timeline.diff:ticket:11423 I implemented a proof of concept that combines the approaches mentioned in this discussion:

  • workflow "action" strings are stored in ticket_change table
  • ITicketActionController grows a new method for determining what label should be rendered in the timeline, given an action string
  • default_workflow.py component allows action.past_tense = .. configuration

I also noted in comment:1:ticket:11423 that the same system could be reused to make the ticket screen's Change History workflow-aware as well (e.g. "Reopened 2 years ago by cboos" instead of just "Changed 2 years ago by cboos")

comment:12 Changed 4 years ago by anonymous

Cc: Ryan J Ollos added
Milestone: next-minor-0.12.xnext-dev-1.1.x

I think we can consider this for 1.1.3, but just need to wrap up some other work before diving in.

comment:13 in reply to:  11 Changed 4 years ago by Jun Omae

Cc: Jun Omae added

In attachment:workflow-aware-timeline.diff:ticket:11423 I implemented a proof of concept that combines the approaches mentioned in this discussion:

At least,

  • We must not store "action" in ticket_change.field. The name might be used as custom field.
  • return "%sed" % action is not elegant for i18n/l10n.
    • return _("Performed %(action)s", action=action) would be a little bit better than.

comment:14 Changed 3 years ago by Ryan J Ollos

Milestone: next-dev-1.1.xnext-major-releases

Retargetting tickets to narrow focus for milestone:1.2. Please move the ticket back to milestone:next-dev-1.1.x if you intend to resolve it by milestone:1.2.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences .

 
Note: See TracTickets for help on using tickets.