Timeline shows incomplete information about status changes for customized workflow

[anonymous]

Currently 'Timeline' shows details about status transitions only for few standard values ('new', 'reopened' and 'closed') and everything else shows as "status changed", which is not very convenient if custom workflow has more states.

We could have something like records in ticket's change history.

Sample patch is attached.

More generic solution (e.g. show changes in custom fields similarly) could be even better…

[Christian Boos]

Looks interesting, we will test it.

[Christian Boos]

eli can you please have a look at this?

[Eli Carter]

My concern is that the 'status' variable here is going to have problems if someone sets up a workflow with an 'edit' state.

I wonder if the workflow config should support action.past_tense = …

[ThurnerRupert]

no degression to 0.10, seems to unnecessarily block 0.11.

[Eli Carter]

#194 is also related: we may want the verb to differ based on the ticket type.

Also, the verbs we have been using have been based on ticket status, not on the action taken to get to that status.

[Christian Boos]

… and this gets even more complicated due to i18n.

[Remy Blank]

I'd say that the original request could wait for 0.12.1, or even for 0.13.

[ethan.jucovy@…]

In attachment:workflow-aware-timeline.diff:ticket:11423​ I implemented a proof of concept that combines the approaches mentioned in this discussion:

• workflow "action" strings are stored in ticket_change table
• ITicketActionController grows a new method for determining what label should be rendered in the timeline, given an action string
• default_workflow.py component allows action.past_tense = .. configuration

I also noted in comment:1:ticket:11423 that the same system could be reused to make the ticket screen's Change History workflow-aware as well (e.g. "Reopened 2 years ago by cboos" instead of just "Changed 2 years ago by cboos")

[anonymous]

I think we can consider this for 1.1.3, but just need to wrap up some other work before diving in.

[Jun Omae]

In attachment:workflow-aware-timeline.diff:ticket:11423​ I implemented a proof of concept that combines the approaches mentioned in this discussion:

At least,

• We must not store "action" in ticket_change.field. The name might be used as custom field.
• return "%sed" % action is not elegant for i18n/l10n.
  • return _("Performed %(action)s", action=action) would be a little bit better than.

[Ryan J Ollos]

Retargetting tickets to narrow focus for milestone:1.2. Please move the ticket back to milestone:next-dev-1.1.x if you intend to resolve it by milestone:1.2.