Edgewall Software
Modify

Opened 12 years ago

Last modified 3 years ago

#5170 new enhancement

max_diff_bytes should be honored even if only one file has changed

Reported by: maz <mzizka@…> Owned by:
Priority: low Milestone: next-major-releases
Component: version control/changeset view Version: 0.10.3.1
Severity: normal Keywords: memory paging
Cc: Branch:
Release Notes:
API Changes:

Description

As mentioned in r2968, the max_diff_bytes rule is ignored if only one file has changed; the differences are then shown inline. This means that if we have lots of changes in one file only (such as often happens here with huge XML files saved by our software), they are shown directly in the main changeset view.

In find this problematic as I often like to review recent changes by using the "previous changeset" and "next changeset" links in the main changeset view. When encountering a change in one of our huge files, I sometimes have to wait several minutes as the browser tries to display the enormous diff. I still want the ability to view minor changes inline, but I want the max_diff_bytes rule to be followed regardless of the number of files that have changed (even just one). Of course, the big diffs should still be accessible through a link.

I will try to create a patch for this when time allows.

Attachments (1)

patch-max_diff_file_size.diff (2.2 KB ) - added by VitalieL 12 years ago.
patch for max_diff_file_size

Download all attachments as: .zip

Change History (10)

comment:1 by Christian Boos, 12 years ago

I understand the reasoning, but shouldn't there be way to force that changeset to be viewed?

in reply to:  1 comment:2 by maz <mzizka@…>, 12 years ago

Replying to cboos:

I understand the reasoning, but shouldn't there be way to force that changeset to be viewed?

Indeed, I will take this into consideration.

A message from mrenzmann on trac-users also drew my attention. His patch allows removal of diff output for certain file types (based on a pattern). This would also be a nice feature, although here again there should still be a way to "force" diff view.

comment:3 by VitalieL, 12 years ago

I think that trac also need max_diff_file_size, because it takes a lot of memory to process big files:

about 700Mb to generate diff for 30Mb file, even diff result is small < 2Mb.

Big files can be skipped with message in html diff: file too large, skipped.

It can be useful to check trac-users discussion .

by VitalieL, 12 years ago

patch for max_diff_file_size

comment:4 by Christian Boos, 11 years ago

Keywords: memory paging added
Milestone: 0.10.50.11.1

This feature can be seen as an additional way to keep the memory usage of Trac under control, so I'm scheduling it for 0.11-stable.

comment:5 by Christian Boos, 10 years ago

Milestone: 0.11-retriage0.11.5

comment:6 by Christian Boos, 10 years ago

#7035 closed as duplicate (timeout while rendering big changesets).

comment:7 by Christian Boos, 10 years ago

Milestone: 0.11.60.12.1

comment:8 by Christian Boos, 9 years ago

Milestone: next-minor-0.12.xnext-major-0.1X
Priority: normallow

patch-max_diff_file_size.diff probably no longer applies.

comment:9 by Ryan J Ollos, 4 years ago

Owner: Christian Boos removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.