Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#5156 closed defect (duplicate)

history view of page edits in inline mode doesn't wrap changed text in Safari or Firefox

Reported by: tmorrison@… Owned by: Jonas Borgström
Priority: low Milestone:
Component: general Version: 0.10.3
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Emmanuel Blot)

when viewing a page if one hits the "Last Revision" link in the upper right area you get the diff page.

  • OS X version 10.4.8.
  • version of trac is 0.10.3
  • Safari version: "Version 2.0.4 (419.3)"
  • Firefox version is: 2.0.0.1

If you select "side-by-side" as the view mode it properly wraps the text being diff'd. If you then go back to "inline" it is broken again - the text goes off the right edge of the window.

Ah hah, further looking indicates that it is only the text that is marked as having changed that is not wrapping. So, to see this you need a large section of text to have been changed such that there is more changed text than will fit in the width of the window.

I've attached a screen shot (png) - look at the right edge to see the problem.

thanks.

Attachments (0)

Change History (6)

comment:1 by Emmanuel Blot, 18 years ago

Version: 0.10.3

Please fill in the "version" field when submitting a new ticket.

comment:2 by Emmanuel Blot, 18 years ago

Description: modified (diff)

comment:3 by Matthew Good, 18 years ago

Keywords: needinfo added

How does this look in your browser? There was a CSS issue that prevented line wrapping in the highlighted part of the diff like you describe (see #1420), but this was fixed for 0.10.3. Try pressing Shift+F5 or Shift+Ctrl+R to force a full refresh of the page to try to make sure you don't have a stale version of the CSS in the cache. Also compare your CSS to the changes made in r4622 to make sure that it is the latest.

comment:4 by tmorrison@…, 18 years ago

This link you indicate ("this" above) looks fine. We are supposedly using 0.10.3 and it does not look ok. I tried refreshing and force refreshing and no change. I'm on a different computer now and same thing. I hit Empty Cache and tried again. same thing. Interestingly, I do not see that we have the change indicated in the r4622 you link to so maybe our "0.10.3" version is not a full update (?). I'll ask the guy who does that here and let him know we may not have gotten all the 0.10.3 source.

thanks.

comment:5 by Matthew Good, 18 years ago

Resolution: duplicate
Status: newclosed

Oops, sorry. Looking at the history that change was not made until after 0.10.3, so it will be included in 0.10.4 (I've corrected the milestone on the other ticket) instead which will be released shortly. So, this ticket is actually a duplicate of #1420.

comment:6 by Matthew Good, 18 years ago

Keywords: needinfo removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.