Collapsible diff display

[jamesm@…]

It would be nice to have a button on each diff section to collapse each the diff section/file. In this way you could display only the file diff you are interested in rather than having to display all the diffs.

[daniel]

This is a neat idea. Some javascript to do the trick would be quite sufficient.

[agr30@…]

I have given it a try and wrote some javascript to do this. Works on Opera 7.5 and Mozilla 0.9 on Linux, needs to be tested on other setups by someone.

The look has to be pimped up obviuosly.

See the attached files.

[agr30@…]

Javascript Code

[agr30@…]

Patch for Template

[agr30@…]

Patch for CSS

[agr30@…]

Fixed fold.js

[agr30@…]

Fixed fold.js to compensate for Internet Explorer's non-W3C compliant event model.

[agr30@…]

When #942 is resolved, fold.js can use the addEvent() function.

[Christian Boos]

This might be done together with #2591.

Note that if you simply hide the elements which are already in the page, you won't get any performance increase: for that, the diff should remain empty until the show triggers the load of additional data (the AJAX way).

If you only want to focus the attention on changes that happened on a specific file, see also #2078.

[markus]

for that, the diff should remain empty until the show triggers the load of additional data

Does that mean all diffs are collapsed when entering the changeset view?

[Christopher Lenz]

I don't think collapsing all diffs by default would be a good idea. Currently, I can quickly get a good overview of the changes just by scrolling through the page. I wouldn't want to first have to expand every diff to see what was actually changed.

Using AJAX here would basically mean the changeset view would be useless without AJAX. I don't think that is acceptable for such an essential feature.

And finally, having the diffs expanded by default, but collapsible by the viewer, doesn't really make much sense at all IMHO. But then again, I've never understood why people think that code folding was such a great feature in editors :-P

[Christopher Lenz]

(Hmm, this should've set the component default owner, but didn't)

[Christian Boos]

cmlenz, the AJAX suggestion was meant for big changesets only. The fallback when Javascript/AJAX isn't available would be a link to the restricted changeset (cf. #2591).

[Christian Boos]

#7070 asked for this feature again.

I actually have a patch to add a Hide button to each diff, in addition to the Tabular and Unified buttons, and a second patch to add those 3 buttons at the top of the diff list. That's a start, but I have yet to add some logic for downloading the diff content on demand, when needed for big changesets.

[Markus.Staab]

using jquery now this should be no prolem..

[Christian Boos]

Too big enhancement for a minor version.