[4982] breaks title attributes

[johann@…]

The bogus patch that I initially submitted as a workaround for #4611 has been applied in [4982] and breaks the title attributes (tooltips). It should be reverted.

I mean only the two diffs in admin_spammonitor.html here: ​http://trac.edgewall.org/changeset/4982#file1

The other changes in [4982] are okay (and incomplete, but I will file another ticket for that).

Before my bogus patch was applied, the construct "x and y or z" was used a backwards-compatible expression for "y if x else z" (which is only available in Python 2.5 and above).

Old behaviour (before [4982]) is correct.

>>> author = 'Author with more than 25 characters'
>>> len(author) > 25 and author or None
'Author with more than 25 characters'

New behaviour (after [4982]) is incorrect, it displays 'True' instead of the author:

>>> author = 'Author with more than 25 characters'
>>> author and len(author) > 25 or None
True

Sorry for the confusion with my bogus patch. I should have removed it when I realized that it didn't fix the problem.

[osimons]

Fixed as [6418].