Edgewall Software
Modify

Opened 13 years ago

Closed 7 years ago

Last modified 7 years ago

#4926 closed defect (fixed)

Mainnav looks funny in IE7

Reported by: anonymous Owned by: Jonas Borgström
Priority: normal Milestone: 1.0
Component: general Version: 0.10.3
Severity: minor Keywords: layout css ie7
Cc: Branch:
Release Notes:
API Changes:

Description

The little triangle in the corner of the main nav buttons is shifted one pixel to the left in IE 7.

In Trac.css:

#mainnav :link, #mainnav :visited {
 background: url(../dots.gif) 0 0 no-repeat;
 border-right: 1px solid #fff;
 border-bottom: none;
 border-left: 1px solid #555;
 color: #000;
 padding: .2em 20px;

Changing the line

background: url(../dots.gif) 0 0 no-repeat;

to

background: url(../dots.gif) 1px 0px no-repeat;

seems to solve the problem in both browsers. Not sure if this adversely affects other browsers (Firefox, Opera, Safari, etc)

Tested in IE7 on XP SP2.

Attachments (0)

Change History (9)

comment:1 by Christian Boos, 13 years ago

Keywords: layout added
Milestone: 0.12
Severity: trivialminor

Well, the main navigation bar has plenty of issues in Internet Explorer, like:

  • text doesn't fit the tabs on zooming
  • the tabs overlap when the page is narrowed

OTOH, the t.e.o main menu (Home, Weblog, Trac, Genshi, Python Sidebar) behaves very nicely both with Firefox and IExplorer, so the corresponding CSS should probably be used for the regular Trac main nav bar as well.

comment:2 by Christian Boos, 9 years ago

Keywords: css bitesized added

It shouldn't be hard to get the appropriate CSS fixes so that the "buttons" flow nicely when the page is resized.

comment:3 by lkraav <leho@…>, 7 years ago

IE7 is seriously antiquated and some services are imposing a monetary tax on its users. I suggest just closing this.

comment:4 by Christian Boos, 7 years ago

Milestone: next-major-releasesnext-stable-1.0.x

Well, as the "funny accents" will be gone soon with the #10012 changes, we could effectively either close this … or recycle it for the next immediate problem I have with IE (with IE8 even) and the new mainnav bar.

comment:5 by Christian Boos, 7 years ago

Keywords: ie7 added; dots.gif bitesized removed
Summary: Mainnav accent (dots.gif) looks funny in IE7Mainnav looks funny in IE7

Ok, so look at demo-0.13 with IE7, and the "new" problem is quite clear… The new wrapping behavior of the navigation bars relies on .nav li { display: inline-block }, which is unfortunately not supported in IE7.

A workaround for that browser (even without the wrapping behavior) would be nice…

in reply to:  6 comment:7 by Christian Boos, 7 years ago

Replying to lkraav <leho@…>:

Maybe this: http://stackoverflow.com/questions/4988727/alternative-for-inline-block-for-ie7

Awesome, it works. Many thanks!

Added in [4747bebf/cboos.git] (and inadvertently first on +testing! well, no big deal).

comment:8 by Christian Boos, 7 years ago

Milestone: next-stable-1.0.x1.0
Resolution: fixed
Status: newclosed

Applied in r11098.

comment:9 by lkraav <leho@…>, 7 years ago

SO ftw, as it usually tends to be these days :>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.