Edgewall Software
Modify

Opened 17 years ago

Closed 16 years ago

Last modified 15 years ago

#4878 closed defect (fixed)

Weird URL handling of additional characters on the end

Reported by: nslater@… Owned by: Remy Blank
Priority: normal Milestone: 0.11.2
Component: timeline Version:
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The following URL should not work:

http://trac.edgewall.org/timeline/bogus

It should either return a 4040 status or a permanent redirect to /timeline

Attachments (1)

4878-stricter-url-matching-r7510.patch (7.3 KB ) - added by Remy Blank 16 years ago.
Patch against 0.11-stable adding stricter URL matching and redirects for URLs with trailing /

Download all attachments as: .zip

Change History (6)

comment:1 by Christian Boos, 17 years ago

Component: generaltimeline
Milestone: 0.11
Owner: changed from Jonas Borgström to Christian Boos
Severity: normaltrivial

comment:2 by anonymous, 17 years ago

Please note that this effects all areas of Trac - not just the timeline.

comment:3 by Remy Blank, 16 years ago

Owner: changed from Christian Boos to Remy Blank

I'll try to implement the suggestions discussed in this thread, more specifically:

  • Be more restrictive in URL matching.
  • Redirect "{url}/" to "{url}" when no handler matches the former.

by Remy Blank, 16 years ago

Patch against 0.11-stable adding stricter URL matching and redirects for URLs with trailing /

comment:4 by Remy Blank, 16 years ago

The patch above implements stricter URL matching, and redirects URLs with a trailing / for which no handler has been found. All unit tests pass.

Comments?

comment:5 by Remy Blank, 16 years ago

Milestone: 0.11.30.11.2
Resolution: fixed
Status: newclosed

Patch applied in [7549].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.