Trac incorrectly process "use_short_addr" option in notification.py

[swl181@…]

if option "use_short_addr" set to true, then TRAC does not append "smtp_default_domain" to short address.

I correct this invalid behaviour by attached patch

[Emmanuel Blot]

Yes, this was the expected behaviour.

From TracIni#notification-section:

"Permit email address without a host/domain (i.e. username only). The SMTP server should accept those addresses, and either append a FQDN or use local delivery"

Maybe this behaviour should be changed, but we need to check first whether the proposed patch could bring some regression.

[anonymous]

Thanks, you are right

I'm incorectly undestood "use_short_addr" option usage

[Emmanuel Blot]

('closed' is reserved for tickets that have led to code change).

Feel free to re-open if you believe that the proposed feature would have been useful.

[Koen Werdler <werdlerk@…>]

This bug still exists if you have users with an e-mail address like "firstname.surname" which is a correct e-mail address for local delivery.

However this is seen by Trac as an invalid e-mail address and is ignored. (Even with the use_short_addr property set to true.)

This is the output when I tried resetting my password (which I used as a testcase for notification):

2007-07-20 14:49:28,500 Trac[notification] INFO: Invalid email address: koen.werdler
2007-07-20 14:49:28,500 Trac[notification] INFO: no recipient for a ticket notification

[sid]

Koen, Check your version of Trac and if it isn't 0.10.4, please upgrade. The current trunk regular expression for shorter emails addresses should handle periods, underscores, dashes, and alphanumeric characters just fine:

class NotifyEmail(Notify):
    """Baseclass for notification by email."""
...
    nodomaddr_re = re.compile(r'[\w\d_\.\-]+')