view attachment of a patch omit the second file

[anonymous]

In ​http://trac.gnugo.org/gnugo/ticket/149 there is simple patch, impacting 2 files.

when clicking on the patch to view it (​http://trac.gnugo.org/gnugo/attachment/ticket/149/patterns2-endgame.diff) we see only the diff for the first impacted file, but not the second :(

[sid]

Interesting.. it looks like the #!diff WikiProcessor is stripping part of the content. Here is the patch (I truncated a few parts to just display the relevant bug) in a normal block:

--- /Big/GO/TGZ/gnugo-3.7.10-ref/./patterns/endgame.db	2006-01-27 16:49:24.000000000 +0100
+++ ./patterns/endgame.db	2006-11-30 13:27:13.000000000 +0100
@@ -1632,22 +1640,22 @@
 #
 ######################################################################
 
-
-Pattern CF3
+#al1 remove pattern
+#Pattern CF3
 # tm New Pattern (3.1.23) (see arend:36)
 # FIXME: Perhaps better in patterns.db?
 # gf This pattern is redundant because the followup has already been
 #    found by find_worm_threats(). (This was broken in 3.1.23 and 3.1.24.)
 
-O*.O  threaten to save
+#O*.O  threaten to save
 
-:-,-
+#:-,-
 
-b*ca
+#b*ca
 
-; dead(a) && !dead(b) && oplay_disconnect(*,*,a) && !oplay_attack(*,?,c,a)
+#; dead(a) && !dead(b) && oplay_disconnect(*,*,a) && !oplay_attack(*,?,c,a)
 
-> threaten_to_save(a)
+#> threaten_to_save(a)
 
 
 ######################################################################
--- /Big/GO/TGZ/gnugo-3.7.10-ref/./patterns/patterns2.db	2006-05-21 19:04:27.000000000 +0200
+++ ./patterns/patterns2.db	2006-11-30 13:25:26.000000000 +0100
@@ -2987,8 +2987,9 @@
 ;oplay_attack(*,A)
 
 
-Pattern Sente13
+Pattern RevSente13
 # gf Revised constraint. (3.1.20)
+# al1 revised symetry, (3.7.11)
 
 *O
 

and then the same section with #!diff prepended.

./patterns/endgame.db

@@ -1632 +1640 @@
 #
 ######################################################################
 
-
-Pattern CF3
+#al1 remove pattern
+#Pattern CF3
 # tm New Pattern (3.1.23) (see arend:36)
 # FIXME: Perhaps better in patterns.db?
 # gf This pattern is redundant because the followup has already been
 #    found by find_worm_threats(). (This was broken in 3.1.23 and 3.1.24.)
 
-O*.O  threaten to save
+#O*.O  threaten to save
 
-:-,-
+#:-,-
 
-b*ca
+#b*ca
 
-; dead(a) && !dead(b) && oplay_disconnect(*,*,a) && !oplay_attack(*,?,c,a)
+#; dead(a) && !dead(b) && oplay_disconnect(*,*,a) && !oplay_attack(*,?,c,a)
 
-> threaten_to_save(a)
+#> threaten_to_save(a)
 
 
 ######################################################################

./patterns/patterns2.db

@@ -2987 +2987 @@
 ;oplay_attack(*,A)
 
 
-Pattern Sente13
+Pattern RevSente13
 # gf Revised constraint. (3.1.20)
+# al1 revised symetry, (3.7.11)
 
 *O
 

[Christian Boos]

Works fine on trunk.

Not sure it's worth backporting on 0.10.x, as the code has started to diverge (and probably will still evolve even more…)

Proposing a worksforme here.

[anonymous]

Hi again. The patch on GNU Go trac have been changed and now display is correct ​http://trac.gnugo.org/gnugo/attachment/ticket/149/patterns2-endgame.diff

The new patch has been made with "cvs diff" instead of "diff" against a tarball, so now the patch has "index" references and is correctly displayed. (/alain)

[Christian Boos]

Ok, then I'm closing it.