Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#4268 closed defect (invalid)

viewing timeline fails

Reported by: florian Owned by: Jonas Borgström
Priority: high Milestone:
Component: timeline Version: devel
Severity: critical Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

How to Reproduce

While doing a GET operation on /timeline, Trac issued an internal error.

System Information

Python 2.3.4 (#1, Sep 26 2006, 17:23:01)
[GCC 3.4.6 20060404 (Red Hat 3.4.6-3)]
Subversion 1.4.0
SQLite 3.3.8
pysqlite 2.3.2
trac r4353

Python Traceback

Traceback (most recent call last):
  File "/root/packages/trac/trac/web/main.py", line 395, in dispatch_request
    dispatcher.dispatch(req)
  File "/root/packages/trac/trac/web/main.py", line 227, in dispatch
    content_type)
  File "/root/packages/trac/trac/web/chrome.py", line 541, in render_template
    return stream.render(method, doctype=doctype)
  File "build/bdist.linux-i686/egg/genshi/core.py", line 141, in render
  File "build/bdist.linux-i686/egg/genshi/output.py", line 200, in __call__
  File "build/bdist.linux-i686/egg/genshi/output.py", line 488, in __call__
  File "build/bdist.linux-i686/egg/genshi/output.py", line 436, in __call__
  File "build/bdist.linux-i686/egg/genshi/core.py", line 202, in _ensure
  File "build/bdist.linux-i686/egg/genshi/core.py", line 202, in _ensure
  File "/root/packages/trac/trac/web/chrome.py", line 561, in _strip_accesskeys
    for kind, data, pos in stream:
  File "build/bdist.linux-i686/egg/genshi/core.py", line 202, in _ensure
  File "/root/packages/trac/trac/web/chrome.py", line 550, in _generate
    for kind, data, pos in stream:
  File "build/bdist.linux-i686/egg/genshi/filters.py", line 147, in __call__
  File "build/bdist.linux-i686/egg/genshi/template.py", line 1148, in _match
  File "build/bdist.linux-i686/egg/genshi/filters.py", line 147, in __call__
  File "build/bdist.linux-i686/egg/genshi/template.py", line 1123, in _match
  File "build/bdist.linux-i686/egg/genshi/template.py", line 1112, in _strip
  File "build/bdist.linux-i686/egg/genshi/template.py", line 902, in _eval
  File "build/bdist.linux-i686/egg/genshi/template.py", line 960, in _flatten
  File "build/bdist.linux-i686/egg/genshi/template.py", line 954, in _flatten
  File "build/bdist.linux-i686/egg/genshi/template.py", line 456, in __call__
TemplateRuntimeError: unpack non-sequence (/usr/share/trac/templates/timeline.html, line -2)

Attachments (0)

Change History (8)

comment:1 by Christian Boos, 17 years ago

Which Genshi version are you using?

Is the problem reproducible with Genshi trunk?

comment:2 by florian, 17 years ago

I checked back to which changeset introduces the error.

r4334 introduces the problem for me. r4333 works fine.

comment:3 by Christian Boos, 17 years ago

Ok, so most likely you're using the pre-r4334 templates.

Check your TracIni [trac] templates_dir location. Ideally, that parameter should be commented out.

comment:4 by florian, 17 years ago

I tried removing/commenting the templates_dir location in the projects trac.ini, that didn't work. I also tried genshi:r462, but that didn't help either.

comment:5 by Christian Boos, 17 years ago

Are you _sure_ the template you think is used really gets used? Put some <h1>CHECK<h1> tags around in the timeline.html… Same for the timeline.py, put some print 'HELLO' statements…

I'm pretty sure this issue is simply a mismatch between a pre-r4334 template and a post-r4333 timeline.py …

comment:6 by florian, 17 years ago

Resolution: invalid
Status: newclosed

Right, so after I ln -s /mycheckedouttrac /usr/share/trac it works.

So it was indeed going against the wrong templates. The thing is, setup.py develop doesn't take care of that, easy_install ./trac doesn't even write the stuff to /usr/share, only setup.py install writes the templates to /usr/share/trac.

(on a sidenote, setuptools has ways and means to get resources out of packages regardless if it's zipped/unzipped eggs or development mode, that might be a good idea to package templates actually)

The resolution of this one: link in the right shared documents.

comment:7 by Christian Boos, 17 years ago

Great! Glad you sort it out.

As side-note too, Trac setup.py doesn't work well with setuptools right now, but this is actively worked on in the source:sandbox/setuptools branch.

comment:8 by Christian Boos, 17 years ago

Milestone: 0.11

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.