iCalendar export: no URL encoding in URL Property

[s.becker@…]

When using whitespace (or other special characters) in milestone names (e.g. "M001 KW42") and exporting the roadmap via iCalendar, the URL property should contain an URL encoded value.

E.g.

URL:http://some.host/trac/milestone/M001%20KW42

instead of

URL:http://some.host/trac/milestone/M001 KW42

[Christian Boos]

PatchWelcome

[Thijs Triemstra <lists@…>]

Confirmed, content below, but the browser redirects to the correct url though..

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Edgewall Software//NONSGML Trac 0.12.1dev-r10147//EN
METHOD:PUBLISH
X-WR-CALNAME:My Project - Roadmap
BEGIN:VEVENT
UID:</milestone/M001 KW42@localhost:8080>
DTSTAMP:20110929T160000Z
DTSTART;VALUE=DATE:20110929
SUMMARY:Milestone M001 KW42
URL:http://localhost:8080/milestone/M001 KW42
END:VEVENT
END:VCALENDAR

[osimons]

I had a look at the code, and it looks wrong - much like the code goes out of its way to avoid encoding? Anyway, if we treat it like any other URL it should be fine:

0.12-stable/trac/ticket/roadmap.py

@@ -444 +444 @@
                 write_date('DTSTART', milestone.due)
                 write_prop('SUMMARY', _('Milestone %(name)s',
                                         name=milestone.name))
-                write_prop('URL', req.base_url + '/milestone/' +
-                           milestone.name)
+                write_prop('URL', req.abs_href.milestone(milestone.name)
                 if milestone.description:
                     write_prop('DESCRIPTION', milestone.description)
                 write_prop('END', 'VEVENT')

I've searched ​rfc:2445 for information, but it says nothing apart from identifying it as a URL - leaving it to regular handling. Like we do through a Href() instance.

Could you test the patch?

[Thijs Triemstra <lists@…>]

ahh.. i came up with:

trac/ticket/roadmap.py

@@ -17 +17 @@
 
 from StringIO import StringIO
 from datetime import datetime, timedelta
+from urllib import quote
 import re
 
 from genshi.builder import tag
@@ -445 +446 @@
                 write_prop('SUMMARY', _('Milestone %(name)s',
                                         name=milestone.name))
                 write_prop('URL', req.base_url + '/milestone/' +
-                           milestone.name)
+                           quote(milestone.name))
                 if milestone.description:
                     write_prop('DESCRIPTION', milestone.description)
                 write_prop('END', 'VEVENT')

I also couldn't find anything special about the URL, or whether the url part in the UID should contain be quoted or not. I'll test your patch.

producing:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Edgewall Software//NONSGML Trac 0.12.1dev-r10147//EN
METHOD:PUBLISH
X-WR-CALNAME:My Project - Roadmap
BEGIN:VEVENT
UID:</milestone/M001 KW42@localhost:8080>
DTSTAMP:20110929T160000Z
DTSTART;VALUE=DATE:20110929
SUMMARY:Milestone M001 KW42
URL:http://localhost:8080/milestone/M001%20KW42
END:VEVENT
END:VCALENDAR

[Thijs Triemstra <lists@…>]

Your patch was missing a ')' at the end but worked fine, cheers. I attached an updated version of the patch.

[osimons]

Oops - mistakes do happen :-) Thanks for testing.

Now that this serious issue of the patch quality itself is under control, I do not see this as a high impact or high risk change. I'd like to just commit this now for 0.12.1 unless anyone objects.

[Remy Blank]

+1

[osimons]

Committed to 0.12-stable in [10149]. Merged to trunk in [10150].