#3865 closed defect (fixed)
Document migration to site.html
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.5 |
| Component: | general | Version: | devel |
| Severity: | normal | Keywords: | initenv inherit patch |
| Cc: | m@…, trudolphi@…, rysiek@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
The files in env/templates/... are not used, thus making CSS or templates tweaks per-environment impossible with latest Trac trunk. This is clearly a regression from previous revisions.
Attachments (1)
Change History (15)
comment:1 by , 18 years ago
follow-up: 3 comment:2 by , 18 years ago
| Priority: | high → normal |
|---|---|
| Severity: | major → normal |
Well, the Clearsilver site_*.cs are no longer used if the page is being rendered using Genshi. Instead, env/templates/site.html is being included if it's present.
We obviously need to add some upgrade instructions for guiding with the migration here.
comment:3 by , 18 years ago
| Cc: | added |
|---|
Replying to cmlenz:
We obviously need to add some upgrade instructions for guiding with the migration here.
Yes, please do so!
comment:5 by , 18 years ago
| Keywords: | documentation added |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
| Summary: | User templates not loaded → Document migration to site.html |
And this post, which would be a starting point for updates to TracInterfaceCustomization.
comment:6 by , 18 years ago
| Cc: | added |
|---|
comment:7 by , 18 years ago
| Milestone: | 0.11.1 → 0.11 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
I believe this was fixed by r5703.
by , 16 years ago
| Attachment: | disable_env_site_template.patch added |
|---|
only create site.html if one is not in shared template path
comment:8 by , 16 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I ran into an issue where the shared template site.html *was not* being used. When creating an environment, a site.html file is written out into env/template. If I remove that, the shared site.html is used. The patch I just attached does not write out a env/template/site.html if one exists in the shared template dir.
comment:9 by , 16 years ago
| Keywords: | initenv inherit added; documentation removed |
|---|---|
| Milestone: | 0.11 → 0.11.3 |
Seems in line with what we do for other settings when using the --inherit flag for creating new environments (TracAdmin#Notes).
Rescheduling to 0.11.3, for integrating attachment:disable_env_site_template.patch.
comment:10 by , 16 years ago
| Cc: | added |
|---|
I second what shanec@… said - env/templates/site.html is clearly not needed (deleted site.html, had no global either), hence it's creation during initenv is superfluous - and as it causes problems when creating a global site.html file (I ran into the very same thing - created the global site.html and started debugging why isn't it used, only to find the default site.html in project env dirs).
I'd say it shouldn't be created in the first place anyway.
comment:11 by , 16 years ago
| Keywords: | patch added |
|---|---|
| Milestone: | 0.11.6 → 0.11.5 |
comment:12 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | reopened → new |
comment:13 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Patch applied in [8147]. Thanks!
comment:14 by , 16 years ago
| Owner: | changed from to |
|---|
Strange, seems to be still there, in Chrome's get_templates_dir.