Edgewall Software
Modify

Opened 18 years ago

Closed 16 years ago

#3838 closed defect (fixed)

When a ticket version is deleted, it does not show what the deleted value was

Reported by: sid@… Owned by: remy.blank@…
Priority: normal Milestone: 0.11.1
Component: ticket system Version: 0.10
Severity: minor Keywords: patch
Cc: remy.blank@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The text shown in the ticket comment is just "Version deleted", but if you want to add back the original value, there is no way to know what to change it back to.

Attachments (1)

3838-ticket-prop-delete-r7376.patch (1.2 KB ) - added by Remy Blank <remy.blank@…> 16 years ago.
Patch against 0.11-stable showing the removed content in ticket property changes

Download all attachments as: .zip

Change History (11)

comment:1 by Christian Boos, 18 years ago

Milestone: 0.11
Severity: normalminor

That's not specific to Version. We could possibly put that information in a tooltip. Alternatives could be:

  • version 0.10 deleted
  • version deleted (was 0.10)

But putting the old value in clear text as above could be mistaken for a set to…, when scanning rapidly.

comment:2 by sid <sid.wiesner@…>, 18 years ago

Strange, I never got an email update from this ticket.

Anyway, I think adding to a tooltip is good. I just would like a way to see the previous version. This might be nice for the other fields as well, but could be problematic if you tried it with the description field.

comment:3 by Noah Kantrowitz (coderanger) <coderanger@…>, 18 years ago

Also if you have TicketDelete installed, that shows the full content of all changes.

comment:4 by Remy Blank <remy.blank@…>, 16 years ago

Cc: remy.blank@… added

Is this feature still desired? If yes, I would like to try and provide a fix.

If I understand the comments above, the old value could be either provided inline or in a tooltip. As any other changes are reported inline (in particular, "changed from … to …"), it would probably be more consistent to display the previous value inline. Personally, I like the format "deleted 0.10".

Please let me know which solution is preferred, and I'll start working on it.

comment:5 by Christian Boos, 16 years ago

Milestone: 0.11.20.11.1
Owner: changed from Jonas Borgström to remy.blank@…

What do you mean by "deleted 0.10"?

  1. milestone deleted 0.10
  2. milestone 0.10 deleted
  3. milestone deleted (was 0.10)
  4. milestone deleted

I think 1. looks funny, I'm afraid 2. and 3. can be mistaken for a "set" (but maybe that's just me). 4. (with the tooltip) is fine except when printed out (we may tweak the css to show more when printing, but I'm not sure it's worth the added complexity).

in reply to:  5 comment:6 by Remy Blank <remy.blank@…>, 16 years ago

Replying to cboos:

What do you mean by "deleted 0.10"?

  1. milestone deleted 0.10

Yes, that's what I meant. It does look funny, but I thought that this would be the most consistent with the other "events". Or what about "deleted from …":

  • milestone set to 0.10
  • milestone changed from 0.10 to 0.11
  • milestone deleted from 0.11

Mmh, not really correct English, I guess…

  1. (with the tooltip) is fine except when printed out (we may tweak the css to show more when printing, but I'm not sure it's worth the added complexity).

I would rather not use a tooltip, as it is not consistent with the way the other changes are reported.

I'll start with the "deleted (was …)" version above, and we can tweak the string formatting after having looked at a few real-world samples.

comment:7 by ebray <hyugaricdeau@…>, 16 years ago

I agree with Remy— "deleted (was…)" makes the most sense. I think if it's italicized or something it would help in scanning. It's really the most clear option, and doing stuff with tooltips and CSS makes it more complicated than necessary.

But it would definitely be nice to have this. It's particularly useful for when ticket vandalism occurs.

by Remy Blank <remy.blank@…>, 16 years ago

Patch against 0.11-stable showing the removed content in ticket property changes

comment:8 by Remy Blank <remy.blank@…>, 16 years ago

I finally implemented the following version:

  • milestone 0.11 deleted

Indeed, this is how reporter or owner deletion was already displayed (see bottom of TicketModule._render_property_diff()).

The same change was also added to the ticket RSS feed.

comment:9 by Remy Blank <remy.blank@…>, 16 years ago

Keywords: patch added

comment:10 by Christian Boos, 16 years ago

Resolution: fixed
Status: newclosed

Looks really good like that and indeed it was already done for owner

Patch applied in r7382.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain remy.blank@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from remy.blank@… to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.