Edgewall Software
Modify

Opened 18 years ago

Closed 16 years ago

Last modified 15 years ago

#3836 closed defect (worksforme)

Author value in RSS feed is not compliant with RSS 2.0 specs.

Reported by: Emmanuel Blot Owned by: Emmanuel Blot
Priority: lowest Milestone:
Component: general Version: 0.10
Severity: minor Keywords: needinfo genshi
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Quoting RSS specification

<author> is an optional sub-element of <item>.
It's the email address of the author of the item. 

Trac fills in the author value, whatever its kind: the author name, or the email address if it exists.

Should we disable the author tag for users without an email address?

Attachments (0)

Change History (6)

in reply to:  description ; comment:1 by Matthew Good, 18 years ago

Keywords: needinfo added; rfc removed

Replying to eblot:

Trac fills in the author value, whatever its kind: the author name, or the email address if it exists.

Should we disable the author tag for users without an email address?

AFAICT it already only includes emails, not simply names:

    if:event.author.email ?>
     <author><?cs var:event.author.email ?></author><?cs
    /if ?>

Am I missing something?

in reply to:  1 comment:2 by Emmanuel Blot, 18 years ago

Replying to mgood:

Am I missing something?

For timeline_rss.cs, you're right. However, for the other RSS sources, you can find:

$ grep -i '<author>' templates/*
templates/log_rss.cs:     if:change.author ?><author><?cs var:change.author ?></author><?cs
templates/query_rss.cs:     <author><?cs var:result.reporter ?></author><?cs
templates/report_rss.cs:   <?cs if:author ?><author><?cs var:author ?></author><?cs /if ?>
templates/ticket_rss.cs:    if:change.author ?><author><?cs var:change.author ?></author><?cs
templates/timeline_rss.cs:     <author><?cs var:event.author.email ?></author><?cs

change.author, for example, produces an invalid feed.

comment:3 by Christian Boos, 18 years ago

Note also that in various places in the code, the value of change.author will actually depend on the format used (i.e. it's often special cased for RSS). That's a bit error prone, for sure, but I wouldn't invest too much time on that, as we can use the migration to Genshi as an opportunity to improve this (like calling the author validation code directly from the .rss templates).

comment:4 by sid, 17 years ago

Keywords: genshi added

comment:5 by Christian Boos, 17 years ago

Milestone: 0.11
Severity: trivialminor

comment:6 by Christian Boos, 16 years ago

Milestone: 0.11.1
Resolution: worksforme
Status: newclosed

I believe it works correctly for 0.11 now. If someone can identify an issue with <author>, please reopen with the relevant information (Trac server and RSS client version information, sample RSS output…)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Emmanuel Blot.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Emmanuel Blot to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.