Edgewall Software
Modify

Opened 18 years ago

Closed 14 years ago

#3646 closed defect (wontfix)

Mime Viewer doesn't handle mixed line endings

Reported by: anonymous Owned by: Remy Blank
Priority: lowest Milestone:
Component: general Version: devel
Severity: minor Keywords: patch renderer
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Attached is a file that exhibits this behavior (note the line endings on the first 3 lines.

Attachments (1)

sample.diff (309 bytes ) - added by anonymous 18 years ago.
I hope this works

Download all attachments as: .zip

Change History (5)

by anonymous, 18 years ago

Attachment: sample.diff added

I hope this works

comment:1 by Christian Boos, 18 years ago

Keywords: patch renderer added
Milestone: 1.0
Priority: normallowest
Severity: normalminor

comment:2 by Christian Boos, 15 years ago

Milestone: 1.0unscheduled

Milestone 1.0 deleted

comment:3 by Remy Blank, 14 years ago

Milestone: triaging0.13
Owner: changed from Jonas Borgström to Remy Blank

comment:4 by Remy Blank, 14 years ago

Milestone: 0.13
Resolution: wontfix
Status: newclosed

I wouldn't consider sample.diff as having mixed line endings, but rather as having too many line endings. Here's the content as a Python string:

"Index: report/report_member_roster.asp\r\r\n"
"===================================================================\r\r\n"
"--- report/report_member_roster.asp\t(revision 192)\r\r\n"
"+++ report/report_member_roster.asp\t(working copy)\r\r\n"
"@@ -1,4 +1,4 @@\r\n"
" This is a test file\r\n"
"-That doesn't\r\n"
"+That does not\r\n"
" render\r\n"
" correctly.\r\n"

The first four lines have duplicate line endings, so there's an empty line after each line, which is invalid syntax. Python does in fact handle mixed line endings very well:

>>> "111\n222\r333\r\n444".splitlines()
['111', '222', '333', '444']

So I'm closing this as "wontfix".

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.