Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 14 years ago

#3508 closed defect (worksforme)

post-commit hook does not send email notification on close

Reported by: Markus Tacker <m@…> Owned by: Jonas Borgström
Priority: normal Milestone:
Component: general Version: 0.10b1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In r3587 the post-commit hook does not sent email notifications to the reporter, assignee or cc if the ticket gets closed.

Email notifications work normal via the browser.

Attachments (0)

Change History (8)

comment:1 by Markus Tacker <m@…>, 15 years ago

Resolution: worksforme
Status: newclosed

Works again in r3605. Thanks.

comment:2 by anonymous, 15 years ago

Resolution: worksforme
Status: closedreopened

Broken in r3717.

comment:3 by Christian Boos, 15 years ago

Keywords: needinfo added

Don't you have anything more specific to say than just "broken"? Did you also install the upgraded post-commit-hook script that comes with r3717. It may well be that your previously installed script is not compatible anymore with the current Trac code base, so check that first. If it is updated, then try to run it directly on the command line, and report the eventual error this gives you.

comment:4 by clay@…, 15 years ago

Keywords: needinfo removed

As of r3739 (with post-commit-hook script of same revision), the script fails with

Unexpected error while processing ticket ID 50: ticket_changed() takes exactly 4 arguments (5 given)

… when I try to close ticket 50 in the project I'm testing with.

comment:5 by Christian Boos, 15 years ago

Keywords: needinfo added

See r3692, the API for ticket_changed has changed there. You probably have a plugin (SpamFilter?) that was not updated to the new API.

comment:6 by clay@…, 15 years ago

Ah, thanks — was indeed a plugin that wasn't updated (timing and estimation from trac-hacks). Once I patched that plugin, the post-commit hook works.

Don't know if that's worthy of closing this ticket, since I didn't open it … but it worksforme at this point.

Thanks!

comment:7 by Christian Boos, 15 years ago

Keywords: needinfo removed
Resolution: worksforme
Status: reopenedclosed
Version: devel0.10b1

Thanks for the feedback!

comment:8 by disordr+trac@…, 14 years ago

I was having a similar issues with my trac-post-commit hook not sending email after it closed a ticket. here are more details: trac version 10.4 post commit script from http://trac.edgewall.org/browser/tags/trac-0.10.4/contrib/trac-post-commit-hook

The problem and solution seemed to be: the PYTHON_EGG_CACHE variable was being set to /var/www which my web user (www-data on debian) didn't have write access to. I saw this problem when running the script as the www-data user on the command line. fixing the permissions on /var/www fixed the emailing problem. I probably could have also altered where PYTHON_EGG_CACHE was pointing to. Just wanted to post this fix, since I didn't see it mentioned anywhere in my google searches. Thanks! -Philip

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.