Ticket Delete Bug

[coderanger@…]

From the looks of the code, when deleting a ticket it will delete the attachment metadata in the db, but not the actual files. Over time these could build up and cause problems.

[Emmanuel Blot]

Not sure to understand this point:

The delete code​ looks like this:

        if os.path.isfile(self.path):
            try:
                os.unlink(self.path)
            except OSError:
                ...

so the file is actually deleted, isn't it?

[Matthew Good]

Replying to eblot:

Not sure to understand this point:

The delete code​ looks like this: …snip… so the file is actually deleted, isn't it?

Yes, but that code is not called when deleting a ticket. The Ticket.delete() method deletes the rows directly from the database without removing the files: trunk/trac/ticket/model.py@3544#L308​

[Christian Boos]

Right, we should use Attachment.delete() for deleting the attachments.

[Christian Boos]

Done in r3595.

The only remaining "issue" is that the empty attachment ticket folder is left behind. If you think it would be cleaner to remove that too, just let me know.