Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#3410 closed defect (fixed)

No way to inline an image URL

Reported by: Alec Thomas Owned by: Christian Boos
Priority: normal Milestone: 0.10
Component: wiki system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Previously, simply inserting an image URL would inline the image. This has recently changed (not sure why?) and it no longer seems possible to display URL images inline at all. [[Image(<url>)]] does not work either, as it appears to only accept attachments.

Attachments (0)

Change History (10)

comment:1 by Emmanuel Blot, 18 years ago

Alec, I think this is a duplicate of #3374.

It seems however that using a URL instead of the Image macro is a regression, as it is not possible to define style for this kind of image (position, size, …). I might be wrong.

comment:2 by Alec Thomas, 18 years ago

That ticket is related, but not a duplicate.

The crux of the matter is that it is no longer possible to display images by URL. Ideally the Image macro would do this.

comment:3 by Christian Boos, 18 years ago

Component: generalwiki
Milestone: 0.11
Owner: changed from Jonas Borgström to Christian Boos

The code in the Image macro could be cleaned-up and simplified, I have a few ideas about it, but this will have to wait for 0.11.

comment:4 by Alec Thomas, 18 years ago

Should this really wait until 0.11? Inlining images seems like a fairly fundamental thing, particularly as it used to work.

comment:5 by Christian Boos, 18 years ago

Well, yes a quick solution for adding http: could be done for 0.10.

I was talking about a more general solution for interpreting any kind of links, using wiki_to_link or similar, and that should wait for 0.11.

comment:6 by Christopher Lenz, 18 years ago

Milestone: 0.110.10

Oh, I thought the [[Image]] macro supported external URLs. That's what this ticket is about, so let's fix it for 0.10.

comment:7 by Christian Boos, 18 years ago

Resolution: fixed
Status: newclosed

Ok, implemented in r3533.

comment:8 by simon-code@…, 18 years ago

Resolution: fixed
Status: closedreopened

Just reviewed and tested the changeset at [3533]. There is an external linktype I'm missing for much of our use - https:

Would it be OK to change the lines in question to:

                elif id in ('http', 'https', 'ftp'): # external URLs
                    raw_url = url = desc = id+':'+file

comment:9 by Christian Boos, 18 years ago

Status: reopenednew

Yeah, ok but after that, let's wait for the much needed refactoring of the wiki parser and macros ;)

comment:10 by Christian Boos, 18 years ago

Resolution: fixed
Status: newclosed

https: added in r3549.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.