Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#3260 closed defect (fixed)

code.css needs modification for php comments when using SilverCity

Reported by: Tim Hatch <trac@…> Owned by: Christian Boos
Priority: normal Milestone: 0.10
Component: version control/browser Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

My SilverCity lexer is producing the class hphp_comment for multiline (c-style) comments. This css class doesn't exist in code.css right now (although hphp_commentblock and hphp_commentinline do). This occurs with the latest SilverCity 0.9.6 built from source.

Patch attached in a sec that fixes the symptom of 'comments not displaying like comments'.

Attachments (1)

silvercity-php-comment.diff (515 bytes ) - added by Tim Hatch <trac@…> 18 years ago.
diff against trunk@3397

Download all attachments as: .zip

Change History (4)

by Tim Hatch <trac@…>, 18 years ago

Attachment: silvercity-php-comment.diff added

diff against trunk@3397

comment:1 by Tim Hatch <trac@…>, 18 years ago

Tested against SilverCity 0.9.5 also, after finding the note about 0.9.6 not working with Trac.

P.S. Tried submitting this comment once, got "Database is locked."

comment:2 by Christian Boos, 18 years ago

Milestone: 0.10
Owner: changed from Jonas Borgström to Christian Boos
Status: newassigned

What's not working with 0.9.6 is the Python highlighting mode. Shouldn't affect the PHP highglighting. I'll apply the patch in a sec.

As for the "Database is locked.", seems to be fairly frequent today :(

comment:3 by Christian Boos, 18 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in r3405.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.