SpamFilter: first setup causes error

[asmodai@…]

I installed the SpamFilter egg in the plugins directory and subsequently proceded to create a BadContent page.

When I submitted I got greeted by a:

Traceback (most recent call last):
  File "/usr/local/lib/python2.4/site-packages/trac/web/main.py", line 300, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.4/site-packages/trac/web/main.py", line 190, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/lib/python2.4/site-packages/trac/wiki/web_ui.py", line 107, in process_request
    self._do_save(req, db, page)
  File "/usr/local/lib/python2.4/site-packages/trac/wiki/web_ui.py", line 211, in _do_save
    req.remote_addr)
  File "/usr/local/lib/python2.4/site-packages/trac/wiki/model.py", line 134, in save
    for listener in WikiSystem(self.env).change_listeners:
  File "/usr/local/lib/python2.4/site-packages/trac/core.py", line 55, in extensions
    return filter(None, [component.compmgr[cls] for cls in extensions])
  File "/usr/local/lib/python2.4/site-packages/trac/core.py", line 186, in __getitem__
    component = cls(self)
  File "/usr/local/lib/python2.4/site-packages/trac/core.py", line 95, in maybe_init
    init(self)
  File "build/bdist.freebsd-4.11-STABLE-i386/egg/tracspamfilter/filters/regex.py", line 33, in __init__
  File "build/bdist.freebsd-4.11-STABLE-i386/egg/tracspamfilter/filters/regex.py", line 57, in _load_patterns
IndexError: list index out of range

Possibly because BadContent is effectively empty at that point until the page gets committed as revision 1.

[Christian Boos]

I could reproduce it: this is happening when the first version of the BadContent page didn't contain a {{{...}}} block.

[Christian Boos]

hm, well, I fixed that error, but then for some reason, the filter doesn't seem to work. As I've no time left to finish investigating this, someone else is welcome to try to fix the regex filter.

Note: I'll be back on Monday

[Christian Boos]

Need to resume work on this…

[Christian Boos]

alec fixed that in r3402.