Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#3184 closed task (fixed)

Using CSS in Image Macro doc is broken

Reported by: anonymous Owned by: Christian Boos
Priority: normal Milestone: 0.10
Component: wiki system Version: 0.9.5
Severity: trivial Keywords: ImageMacro CSS
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I use CSS in the ImageMacro, but since upgrading to 0.9.5 (on debian) I have noticed it is not working. To be specific, I use the following code [[Image(photo.png, float:right)]], which used to display the image on the right. I have seen the bug fix regarding image sizes and percentages, but that fix does not resolve this problem.

Attachments (1)

trac_banner.png (2.1 KB ) - added by Christian Boos 18 years ago.
test image

Download all attachments as: .zip

Change History (5)

by Christian Boos, 18 years ago

Attachment: trac_banner.png added

test image

comment:1 by Christian Boos, 18 years ago

Milestone: 0.9.60.10
Owner: changed from Jonas Borgström to Christian Boos
Summary: Using CSS in Image Macro is brokenUsing CSS in Image Macro doc is broken
Type: defecttask

The syntax has changed slightly. It should be:

[[Image(photo.png, align=right)]] test image

to get a "float: right" image.

I thought that I fixed the doc… Ok, only in 0.9-stable (if you're using 0.9.5, check again your [[MacroList(Image)]] doc).

I'll port that to trunk.

comment:2 by simon-code@…, 18 years ago

I have a similar issue where I have been using padding-left:10px or similar variations of padding: for a number of my images. It has been very useful in getting the right amount of space between image and text when the text flows around it.

This no longer works with version 0.9.5 due to the security tightening of the macro. Could you please add support for padding?

comment:3 by Christopher Lenz, 18 years ago

As we don't want to have to sanitize user-supplied CSS properties in the [[Image]] macro, we have restricted the supported options down to a minimum. If you want extra styling, I would recommend using a class and then define the corresponding style rules in your custom CSS style sheet. The other option is using an #!html block…

While adding back support for specific style properties such as padding is not completely out of the question, I view that as a slippery slope: next we'll need padding on other side, borders on either side, margins when aligned, etc. Where would we stop?

comment:4 by Christian Boos, 18 years ago

Resolution: fixed
Severity: majortrivial
Status: newclosed

Ported documentation update from 0.9-stable in r3353.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.