Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#312 closed defect (fixed)

Extra slash after htdocs_location in generated URLs

Reported by: cmlenz@… Owned by: Jonas Borgström
Priority: normal Milestone: 0.7.1
Component: general Version: 0.6.1
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

Links in pages generated by trac contain an extra slash after the htdocs_location, so that URLs look like

    /trac//css/trac.css

instead of the expected

    /trac/css/trac.css

Attachments (0)

Change History (7)

comment:2 by anonymous, 15 years ago

Milestone: 0.7

comment:3 by Jonas Borgström, 15 years ago

Resolution: wontfix
Status: newclosed

Well, this is actually a feature :) This approach will work even if htdocs_location does not end with a '/'.

But I guess that if it for some reason isn't acceptable to generate urls with double slashes we could apply the patch _and_ add some logic to make sure htdocs_location always has a trailing slash.

comment:4 by cmlenz@…, 15 years ago

Resolution: wontfix
Status: closedreopened

Well, "not acceptable" is a bit strong. But I really think it'd be much better to make the admin get the htdocs_location right, as opposed to adding cruft (albeit minor) to each and every page generated out by Trac.

Alternatively, the htdocs_location should be set to "/trac" instead of "/trac/" by default. That'd probably be the simplest solution.

(Reopening only to get this comment noticed, not because I think the current approach is "not acceptable ;-) )

comment:5 by cmlenz@…, 15 years ago

Also note that many image links (such as the XML icon for RSS feeds and the icons in the timeline) do not handle a htdocs_location without trailing slash.

comment:6 by daniel, 15 years ago

Milestone: 0.70.7.1

comment:7 by Jonas Borgström, 15 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in [527].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.