Exception "int argument required" being raised for tickets not in the system when TracError was expected

[cl_111@…]

While extending the contrib/trac-post-commit-hook to suit the needs of the company I'm currently employed with, I came across the situation where if a ticket number in the commit log is not actually in the trac system then a int argument required exception is being raised when a TracError exception should be expected.

Example code which triggers the issue (assume ticket 10 does not exist):

from trac.env import open_environment
from trac.ticket import Ticket
from trac.core import TracError


if __name__ == "__main__":
    # Change the following to a ticket number not in your trac project.
    tkt_id = 10

    # Change the following to accordingly
    project = "/var/lib/trac"

    env = open_environment(project)
    try:
        ticket = Ticket(env, tkt_id)
     except TracError, e:
         print>>sys.stderr, 'TracError: %s' % (e)
     except Exception, e:
         print>>sys.stderr, 'Unexpected error while retrieving ticket %s: %s.' % (tkt_id, e)

For a ticket not in the system, what is observed on stderr is the Unexpected error while ... message as opposed to the expected TracError: ... message.

I'll attach a diff which corrects the behaviour for 0.9.3.

[cl_111@…]

Diff for ticket/model.py

[Alec Thomas]

This is a usage bug in whatever is calling the Ticket model constructor. tkt_id is supposed to be an integer, so the exception you are receiving is correct. And in fact, your test script works correctly on my copy of Trac stable (0.9.5).

From looking at trac-post-commit-hook, it seems that this patch should be applied:

contrib/trac-post-commit-hook

@@ -145 +145 @@
         for cmd, tkts in cmdGroups:
             if CommitHook._supported_cmds.has_key(cmd.lower()):
                 func = getattr(self, CommitHook._supported_cmds[cmd.lower()])
-                func(ticketPattern.findall(tkts))
+                func([int(i) for i in ticketPattern.findall(tkts)])
 
     def _cmdClose(self, tickets):
         for tkt_id in tickets:

[Alec Thomas]

Hopefully fixed in r3272, please test.

[cl_111@…]

Oops my bad - I copied the wrong version of my test. The tkt_id in my script should have been a string not an integer as follows:

    # Change the following to a ticket number not in your trac project.
    tkt_id = "10"

Anyway your fix to the trac-post-commit-hook does the trick.