to_unicode() special casing Exception

[Alec Thomas]

Should this be handled as it is? It completely ignores the __str__() method of the Exception subclass. In the case of the Permission exception, the user receives an empty red box.

The following patch seems to work fine in the limited cases I've tested, but I didn't commit it because I might not be aware of cases where it doesn't.

trac/util/__init__.py

@@ -91 +91 @@
     the input).
     """
     if not isinstance(text, str):
-        if isinstance(text, Exception):
-            return ' '.join([unicode(arg) for arg in text.args])
         return unicode(text)
     errors = lossy and 'replace' or 'strict'
     try:

[Christian Boos]

svn blame is your friend… More specifically, I did that in order to fix a problem with parse_date. I'll try to come up with a better solution which also takes care of the new problem you mentionned.

[Christian Boos]

No wonder you could remove the check, the unit test I added in r3215 was completely broken… I fixed that in r3255, as well as adding a fix and a test for the error you reported.

(Note: I'm directly committing the fix and closing the issue instead of first attaching a patch here, as I've noticed that the e-mail notifications are currently not working, last message sent: Fri Apr 28 22:35:20 CDT 2006).