Edgewall Software
Modify ↓

Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#3060 closed defect (fixed)

Broken download link in Source-Browser

Reported by: anw@… Owned by: Christian Boos
Priority: high Milestone: 0.10
Component: version control/browser Version: devel
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In r3213 the donwload link in the sourecbrowser for non-previewable files is broken. the cs var:file.raw_href in the browser.cs template is empty. Putting 

req.hdf['file.raw_href'] = raw_href

after 

# add ''Original Format'' alternate link (always)
            raw_href = req.href.browser(node.path, rev=rev, format='raw')

in line 249 would fix this.

Attachments (0)

Change History (3)

comment:1 by Christian Boos, 20 years ago

Owner: changed from Jonas Borgström to Christian Boos
Priority: normal → high
Severity: normal → minor
Status: new → assigned

Oops, sorry. That was the job of the preview_to_hdf method, and there, I have to add the raw_href in all cases (not only when the max_preview_size is reached).

comment:2 by Christian Boos, 20 years ago

Resolution: → fixed
Status: assigned → closed

Should be fixed by r3212.

comment:3 by Christian Boos, 20 years ago

(r3214 I meant, sorry)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.