Include attached files with added attachment e-mail notifications for tickets.

[oscarmv@…]

When adding an attachment to a ticket, the notification e-mail sent should include it as an attachment.

An option could be added to limit this feature to files of up to a certain size.

[anonymous]

Adding attachments to a ticket does not produce a notification.

[Jonas Borgström]

Any reason why we should not send notification e-mails when attachments are added?

A link to the attachment is probably better than attaching it to the notification e-mail, this way we avoid having to add another "maximum file size" option.

[Emmanuel Blot]

This could be a potential security issue, as an attached file might contain a malware.

I think a URL to the actual file would be a better solution.

[Emmanuel Blot]

See also #2259

[Asheesh Agrawal <asheesh.agrawal@…>]

ny update on whether this feature is still active and being looked at??

[Peter Suter]

Could maybe be implemented as a plugin? Untested:

from email.mime.application import MIMEApplication

from trac.core import Component, implements
from trac.notification.api import IEmailDecorator

class AttachmentEmailDecorator(Component):

    implements(IEmailDecorator)

    # IEmailDecorator methods
    
    def decorate_message(self, event, message, charset):
        if event.category == 'attachment added':
            attachment = event.attachment
            filename = attachment.filename
            with attachment.open() as fd:
                part = MIMEApplication(fd.read(), Name=filename)
            part['Content-Disposition'] = 'attachment; filename="%s"' % filename
            message.attach(part)

[Ryan J Ollos]

See also ​th:#11642.

The plugin works well. It would probably be useful to have a debug level log message to indicate that the IEmailDecorator is called.

I favor putting it in the CookBook and closing this ticket. If we get enough requests for the feature we could reconsider adding it to tracopt.

[Peter Suter]

Yes, that sounds good to me. I created wiki:CookBook/Notification/Email.