Minor fix for newly added ExtensionOption

[Alec Thomas]

The current implementation assumes the default is a class, but the uses of it assume it is a string:

trac/config.py

@@ -349 +349 @@
         if instance is None:
             return self
         value = Option.__get__(self, instance, owner)
+        if self.default is not None:
+            value = self.default
         for impl in self.xtnpt.extensions(instance):
             if impl.__class__.__name__ == value:
                 return impl
-        if self.default is not None:
-            return self.default(instance.env)
         raise AttributeError('Cannot find an implementation of the "%s" '
                              'interface named "%s".  Please update the option '
                              '%s.%s in trac.ini.'

[Christopher Lenz]

That would make the default always override the actual value… I think it should suffice to remove the two lines your patch removes, as the default should already be handled by Option.__get__.

[Alec Thomas]

Heh yeah, whoops.

[Alec Thomas]

Fixed in r3192.