Edgewall Software
Modify ↓

Opened 19 years ago

Closed 19 years ago

#3029 closed enhancement (fixed)

Port of WorkFlow ITicketManipulator interface to trunk + addition of ITicketChangeListener interface

Reported by: Alec Thomas Owned by: Christopher Lenz
Priority: normal Milestone: 0.10
Component: ticket system Version: devel
Severity: normal Keywords: spam hook
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Alec Thomas)

These two patches implement the WorkFlow ITicketManipulator interface, and also adds a new ITicketChangeListener interface.

The idea is that plugins can utilise these hooks under 0.10 to perform spam prevention.

Attachments (3)

ticket-change-listener.diff​ (2.3 KB ) - added by Alec Thomas 19 years ago.
ITicketChangeListener interface for trunk
ticket-adjunct-listener.diff​ (4.9 KB ) - added by Alec Thomas 19 years ago.
ITicketAdjunctChangeListener interface
trunk-ticket-manipulator.diff​ (4.1 KB ) - added by Alec Thomas 19 years ago.
ITicketManipulator interface stub for trunk

Download all attachments as: .zip

Change History (10)

by Alec Thomas, 19 years ago

Attachment: ticket-change-listener.diff​ added

ITicketChangeListener interface for trunk

comment:1 by Alec Thomas, 19 years ago

Description: modified (diff)

by Alec Thomas, 19 years ago

Attachment: ticket-adjunct-listener.diff​ added

ITicketAdjunctChangeListener interface

comment:2 by Alec Thomas, 19 years ago

The ITicketAdjunctChangeListener interface methods are called whenever any of the models adjunct to the Ticket model are created/changed/deleted. It's quite a generic interface, but I figured that would be better than having five different interfaces all doing almost the same thing.

comment:3 by Christian Boos, 19 years ago

Keywords: spam hook added
Priority: low → normal
Severity: minor → normal

Suggested docstring changes for ITicketManipulator.validate_ticket:

"Must return a list of (field, message) tuples, one for each problem detected."
"field can be None to indicate an overall problem with the ticket. "
"Therefore, a return value of [] means everything is OK."

by Alec Thomas, 19 years ago

Attachment: trunk-ticket-manipulator.diff​ added

ITicketManipulator interface stub for trunk

comment:4 by Alec Thomas, 19 years ago

Okay, updated.

comment:5 by Christopher Lenz, 19 years ago

Owner: changed from Jonas Borgström to Christopher Lenz
Status: new → assigned

Looks pretty good.

comment:6 by Christopher Lenz, 19 years ago

See also #2176.

comment:7 by Christopher Lenz, 19 years ago

Resolution: → fixed
Status: assigned → closed

Patch applied in [3145], minus the adjunct listener.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.