Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#2917 closed defect (fixed)

MacroList should handle errors in macros

Reported by: pickscrape@… Owned by: Christian Boos
Priority: low Milestone: 0.10
Component: wiki system Version: 0.9.4
Severity: minor Keywords: MacroList inspect macro
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I just hunted down a problem with the MacroList macro, which refused to render: it complained the global object 'inspect' was now defined.

Using the error log I traced this to the graphviz plugin. I added an import for inspect to the top of the graphviz.py, reinstalled the egg, restarted apache and MacroList was working.

One might argue that this is a bug with graphviz, buit I don't know if that's the case or not. Should trac import this automatically for macros, and if not should it not just catch the error and still render documentation for the more 'well-behaved' macros?

Attachments (0)

Change History (3)

comment:1 by Matthew Good, 18 years ago

Summary: !MacroList bails out if a macro doesn't import inspect moduleMacroList should handle errors in macros

Yes, that is a bug in the graphviz plugin. It tries to use the module without importing it. Trac can't import "inspect" automatically, and it's not necessary for it to do so.

However, I'll leave this open since the point about catching those errors is valid.

comment:2 by Christian Boos, 18 years ago

Milestone: 0.10
Owner: changed from Jonas Borgström to Christian Boos

Will follow-up to r3061 with a fix for this.

comment:3 by Christian Boos, 18 years ago

Resolution: fixed
Status: newclosed

Fixed in r3071.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.