Modify ↓
Opened 19 years ago
Closed 19 years ago
#2917 closed defect (fixed)
MacroList should handle errors in macros
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | low | Milestone: | 0.10 |
| Component: | wiki system | Version: | 0.9.4 |
| Severity: | minor | Keywords: | MacroList inspect macro |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
I just hunted down a problem with the MacroList macro, which refused to render: it complained the global object 'inspect' was now defined.
Using the error log I traced this to the graphviz plugin. I added an import for inspect to the top of the graphviz.py, reinstalled the egg, restarted apache and MacroList was working.
One might argue that this is a bug with graphviz, buit I don't know if that's the case or not. Should trac import this automatically for macros, and if not should it not just catch the error and still render documentation for the more 'well-behaved' macros?
Attachments (0)
Change History (3)
comment:1 by , 19 years ago
| Summary: | !MacroList bails out if a macro doesn't import inspect module → MacroList should handle errors in macros |
|---|
comment:2 by , 19 years ago
| Milestone: | → 0.10 |
|---|---|
| Owner: | changed from to |
Will follow-up to r3061 with a fix for this.
Note:
See TracTickets
for help on using tickets.
Yes, that is a bug in the graphviz plugin. It tries to use the module without importing it. Trac can't import "inspect" automatically, and it's not necessary for it to do so.
However, I'll leave this open since the point about catching those errors is valid.