Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#2906 closed defect (fixed)

clicking timeline changeset link errors

Reported by: tscanlan@… Owned by: Alec Thomas
Priority: normal Milestone:
Component: version control/changeset view Version: devel
Severity: normal Keywords: workflow
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In the source:/sandbox/workflow branch, changeset links are broken:

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 283, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 170, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 175, in process_request
    req.check_modified(chgset.date, [
TypeError: pretty_timedelta() takes at most 2 arguments (3 given)

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 18 years ago

Milestone: 0.10
Resolution: invalid
Status: newclosed

pretty_timedelta actually accepts 3 arguments (in trunk or sandbox/workflow). You must have an old trac/util.pyc somewhere… You should wipe out your previous trac installation and reinstall: trac.util is now a package.

comment:2 by anonymous, 18 years ago

Resolution: invalid
Status: closedreopened

actually, look at the setup.py in source:/sandbox/workflow

It doesn't have the package trac.util listed, so it doesn't get installed. But, correct, after adding that the problem is fixed.

comment:3 by Christian Boos, 18 years ago

Keywords: workflow added
Status: reopenednew

Thanks for the clarification. This is fixed in the trunk, so it will end up in the workflow branch during the next sync.

comment:4 by Alec Thomas, 18 years ago

Status: newassigned

I am busily syncing with trunk, along with some other cleanup. Should have another commit ready by the weekend.

comment:5 by Alec Thomas, 18 years ago

Resolution: fixed
Status: assignedclosed

Trunk has been synced in r3048 and r3049.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Alec Thomas to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.