Cannot browse source with space in path name

[Graham Booker]

When browsing source, upon clicking on a directory contain a space in its name, trac cannot find the file/directory. This is against [3008]

Example: ​http://trac.fireim.org/dev/browser/trunk/fire/

Click on any of the directories with a space in the name, such as "Preference Panes"

[Christian Boos]

Can you try this fix?

trac/web/main.py

@@ -20 +20 @@
 import os
 import sys
 import dircache
+import urllib
 
 from trac.core import *
 from trac.env import open_environment
@@ -209 +210 @@
                 raise ValueError('TracUriRoot set to %s but request URL '
                                  'is %s' % (root_uri, request_uri))
             environ['SCRIPT_NAME'] = root_uri
-            environ['PATH_INFO'] = request_uri[len(root_uri):]
+            environ['PATH_INFO'] = urllib.unquote(request_uri[len(root_uri):])
 
     else:
         environ.setdefault('trac.env_path', os.getenv('TRAC_ENV'))

[Christopher Lenz]

What front-end are you using?

[Christian Boos]

#2865 was marked as duplicate. For the reporter, the above fix did work.

Should we commit this?

[bdash]

I can confirm that this fix resolves the issue.

[Christopher Lenz]

Yeah, this looks okay.

[Christian Boos]

Ok, fix applied in r3098.