Edgewall Software
Modify

Opened 19 years ago

Closed 19 years ago

#2838 closed defect (fixed)

trac may not be able to handle svn properties named '.'

Reported by: OHKUBO.Takuya@… Owned by: Christian Boos
Priority: normal Milestone: 0.10
Component: version control/browser Version: 0.9.4
Severity: major Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

I put a SVN property named '.' on a directory by mistake (unfortunately my client 'svk' accepted such a odd request).

Since then, trac source-browser cannot display that directory. If I order trac to do so, it causes an internal error. Changeset browser does not work at that commitment, neither.

Python traceback is below:

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 206, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 139, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 107, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.3/site-packages/trac/versioncontrol/web_ui/browser.py", line 84, in process_request
    req.hdf['browser'] = {
  File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 194, in __setitem__
    self.set_value(name, value, True)
  File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 231, in set_value
    add_value(name, value)
  File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 223, in add_value
    add_value('%s.%s' % (prefix, k), value[k])
  File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 223, in add_value
    add_value('%s.%s' % (prefix, k), value[k])
  File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 218, in add_value
    self.hdf.setValue(prefix, util.escape(value))
Error: Traceback (innermost last):
  File "neo_hdf.c", line 783, in hdf_set_value()
  File "neo_hdf.c", line 773, in _set_value()
AssertError: Unable to set Empty component browser.props..

Attachments (0)

Change History (2)

comment:1 by Christian Boos, 19 years ago

Description: modified (diff)
Owner: changed from Jonas Borgström to Christian Boos
Severity: normalmajor

I'll look into this.

comment:2 by Christian Boos, 19 years ago

Milestone: 0.10
Resolution: fixed
Status: newclosed

Fixed in [2958]. This change fixes not only the pathological case reported here, but also handles correctly any property name containing a dot, like "a.b". Those property names are perfectly valid in SVN.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.