Make external references visually distinct

[daniel]

Links referencing outside trac should be visually distinct, like i other wikis.

This should be done in CSS only.

[Christopher Lenz]

Moving to 0.9.

[cboos@…]

See the patch I attached to #234, which contains an 'external' class.

[cboos@…]

… the relevant part being:

htdocs/css/trac.css

@@ -240 +240 @@
 a.missing:link,a.missing:visited { background: #fafaf0; color: #998 }
 a.missing:hover { color: #000; }
 
+a.external:link,a.external:visited { color: #00b }
+
 #content.wiki { line-height: 140% }
 .wikitoolbar {
  border: solid #d7d7d7;

trac/WikiFormatter.py

@@ -304 +304 @@
             return '<a href="%s">%s</a>' % (self._href.wiki(match), match)
 
     def _url_formatter(self, match, fullmatch):
-        return '<a href="%s">%s</a>' % (match, match)
+        return '<a class="external" href="%s">%s</a>' % (match, match)
 
     def _fancylink_formatter(self, match, fullmatch):
         link = fullmatch.group('fancyurl')
@@ -319 +319 @@
         elif module_link:
             return '<a href="%s">%s</a>' % (module_link, name)
         else:
-            return '<a href="%s">%s</a>' % (link, name)
+            return '<a class="external" href="%s">%s</a>' % (link, name)
 
     def _intertrac_link(self, intertrac):
         href = self.env.get_config('intertrac', intertrac.upper() + '.href')

[Christopher Lenz]

Daniel has implemented this in [1068].

[Juanma Barranquero]

Am I the only one who finds the new external link style a bit heavy-handed? Perhaps a simple color change would have sufficed (yes, I know I can customize to my heart's content, but still… :)

And, if definitely using an icon, wouldn't be better to have it *after* the link, à la ​MediaWiki?

[cboos@…]

I like the new style, and didn't hesitate a split second

to drop my "color-only" change…