Opened 19 years ago
Closed 19 years ago
#2655 closed defect (fixed)
Repeated links in multiline comments
Reported by: | Owned by: | Christopher Lenz | |
---|---|---|---|
Priority: | normal | Milestone: | 0.10 |
Component: | version control/browser | Version: | devel |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
There is a regression caused by r2769 in source:trunk/trac/mimeview/api.py for multiline blocks. I've verified it with the Clearsilver-generated code for both Python and CSS highlighting (I've only noticed it in the browser view). Here's my testcase:
""" a http://google.com/ Test Test """
The bug manifests itself as the following being displayed (without formatting, but you get the idea):
1 """ 2 a http://google.com/ 3 a http://google.comTest 4 a http://google.comTest 5 a http://google.com"""
The anchor tag (and text thus far on the line) appear to be reinserted on subsequent lines until the end of the comment block. This worked correctly prior to r2769. Looking at this changeset, I moved the question mark to more closely reproduce the prior behavior (making dot-star nongreedy, rather than making the capturing group optional).
I'll attach the patch in a second.
Attachments (1)
Change History (3)
by , 19 years ago
Attachment: | multiline-link-regexp-fix.diff added |
---|
comment:1 by , 19 years ago
Milestone: | → 0.10 |
---|---|
Owner: | changed from | to
Status: | new → assigned |
Version: | 0.9.3 → devel |
comment:2 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed in [2828]. Thanks for the patch!
Diff against trunk @ r2824