Trac browser should browse SVN symbolic links

[Alec Thomas <alec@…>]

Here is a patch to add browsing of symbolic links. It has the following behaviour:

• Links outside the repository are normalised to /, but display the full link path.
• Links to non-existent objects will display the default file.

[Alec Thomas <alec@…>]

I've patched this into TracHacks, you can see it in action ​here.

[Alec Thomas <alec@…>]

Actually ​this one is better. It moves the logic of deciding whether a node is a symlink into the version control layer.

[Alec Thomas <alec@…>]

The patch also needs a link.png and linkdeny.png, for which I just copied the file png's.

[Christian Boos]

If there's no objection, I'd like to check in that patch.

[Alec Thomas]

An issue is that the browser file name rows are no longer selectable, you have to click directly on the filename. I couldn't figure out a good way with CSS to achieve this but perhaps somebody more CSS savvy can?

[Christian Boos]

you have to click directly on the filename

Really? By testing your ​sample, it seems that it works as usual (i.e. the whole cell containing the file name is clickable using Firefox, but only the name is, if using IE).

Ah, got it: seems that on Trac Hacks you still have the unmodified CSS. So, are the CSS changes in your patch really needed?

[Alec Thomas]

I'm not actually running it on TracHacks anymore (it got lost in an upgrade :)), but IIRC the CSS changes are necessary, but not quite complete.

[Christian Boos]

Will do later.

[Christian Boos]

#4788 was closed as duplicate.

[Christian Boos]

Looking again at the patch, there's a sequence which seems quite costly:

    for entry in node.get_entries(): 
       if entry.isfile and 'svn:special' in entry.get_properties(): 

I think this should rather be done during synchronization of the changeset, in a way that this information can be reused for browsing, as suggested in VcRefactoring#NewRepositoryCache.

In the meantime, there could be a simpler way to handle svn:special links, see #4788.

[Christian Boos]

PatchWelcome.