Opened 19 years ago
Closed 15 years ago
#2471 closed enhancement (duplicate)
The logo in the left corner should not be named "banner"
Reported by: | anonymous | Owned by: | Jonas Borgström |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | general | Version: | 0.9.2 |
Severity: | minor | Keywords: | packagedata |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
Since many adblocking systems do not load images with "banner" or "adv" text in the filename, it doesnt load.
Attachments (1)
Change History (7)
comment:1 by , 19 years ago
comment:2 by , 19 years ago
Well, renaming it as "project-logo" or something wouldn't be so hard.
Also, maybe you don't need to remove it completely. Maybe make an image like the attachement..
Obviously i only spent 2 minutes making that, so it would need to be refined :]
comment:3 by , 18 years ago
(I agree that way too much TRACs on this planet look like default TRACs. But that is only an opinion…)
How about shipping a set of ugly banners and ugly css-files which show http://trac.edgewall.com/trac/pick1ofthese/ all over the screen and running a trac skin contest before? Edgewall could take the winning skin in exchange for the first price as a new CI, stuff it with ads and leave it closed sourced & trade marked for own use, then ship the default trac package with the "old" skin or the uglifiedy skin mentioned above.
And PLEASE use other, unobtrusive names for #banner <div/> and title image! (see http://groups.google.com/group/trac-users/tree/browse_frm/thread/9c257a607fd7931d/e56ac169f6f5eac7?rnum=1&q=header+rendering&_done=%2Fgroup%2Ftrac-users%2Fbrowse_frm%2Fthread%2F9c257a607fd7931d%2Fe56ac169f6f5eac7%3Ftvc%3D1%26q%3Dheader+rendering%26#doc_885d2b5905b4060f)
There seems to be an issue with adblock plus and <div/> #content, too: (see http://lacucaracha.org/trac/trac_menu_messed_up_under_firefox_with_adblock.jpg)
comment:4 by , 18 years ago
Keywords: | setuptools packagedata added |
---|---|
Milestone: | → 1.0 |
Priority: | high → normal |
There's definitely room for improvement here, but probably not in the immediate future ;)
I like the idea of the attachment:project-logo.png, but that will have to be adapted to the setuptools changes.
comment:5 by , 17 years ago
There is a new ticket (#6185) that has in many ways continued the themeing part of this ticket.
That leaves the original issue of default logo rename - or no logo at all as cmlenz suggests (themeing related). Renaming the banner sure would encourage a lot of sites to figure out how to get their own logo working… Could this ticket somehow be closed and discussions moved to new ticket?
comment:6 by , 15 years ago
Keywords: | setuptools removed |
---|---|
Milestone: | 1.0 |
Resolution: | → duplicate |
Status: | new → closed |
I believe the changes done for #6185 make this ticket obsolete, as there's no default logo anymore.
Well, that is at least an incentive to use your own friggin' logo ;-)
In fact, I've been thinking that we should just remove the logo from the default installation. Way too many projects are carelessly not replacing it with their own.